Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3657 4393 modular explore plus guestbook #4413

Closed
wants to merge 24 commits into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Jan 11, 2018

combo pull request for #3657 and #4393 but now not necessary (closing)

pdurbin and others added 24 commits January 3, 2018 16:00
Update the description for the Data Explorer
Note the FIXME that this is working from the file page but not the
dataset page.
Here we are differentiating between popups for TwoRavens ("explore") and
popups for external tools ("externalTool").
We don't want to show explore tools for images and such until there is a
use case, at which time we can add a column to the externaltool table.
…57-4393-modular-expore-plus-guestbook

Conflicts (just imports):
src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java
@pdurbin pdurbin mentioned this pull request Jan 11, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 12.829% when pulling 3519747 on 3657-4393-modular-explore-plus-guestbook into 48ff5d4 on develop.

@pdurbin
Copy link
Member Author

pdurbin commented Jan 12, 2018

Closing in favor of #4407.

@pdurbin pdurbin closed this Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants