Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing filter for Results By Username #10980

Merged
merged 5 commits into from
Nov 21, 2024

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Oct 29, 2024

What this PR does / why we need it: The “results by username” field under "My Data" SUPERUSER features should display the content created by the "username" inserted in that field. It does not do that in demo or production. Tried with quotes and without, around the username.

Which issue(s) this PR closes: #7239

Special notes for your reviewer:

Suggestions on how to test this: Log in as superuser. Go to MyData. Change "Results by Username" to another user and press enter. See that the list now shows data belonging to the other user.

Does this PR introduce a user interface change? If mockups are available, please link/include them here: No

Is there a release notes update needed for this change?: included

Additional documentation:

@stevenwinship stevenwinship removed their assignment Oct 29, 2024
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A quick comment.

doc/release-notes/7239-mydata-results-by-username.md Outdated Show resolved Hide resolved
Co-authored-by: Philip Durbin <philip_durbin@harvard.edu>
@cmbz cmbz added the FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) label Nov 1, 2024
@coveralls
Copy link

Coverage Status

coverage: 21.856%. remained the same
when pulling fc05b99 on 7239-mydata-results-by-username
into b28812b on develop.

@cmbz cmbz added the FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) label Nov 7, 2024
@sekmiller sekmiller self-assigned this Nov 20, 2024
Copy link
Contributor

@sekmiller sekmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Probably have to update from dev

@sekmiller sekmiller removed their assignment Nov 20, 2024
@ofahimIQSS ofahimIQSS self-assigned this Nov 21, 2024
@cmbz cmbz added the FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) label Nov 21, 2024
@ofahimIQSS
Copy link
Contributor

Merging PR

Testing of 10980.docx

@ofahimIQSS ofahimIQSS merged commit 88e4276 into develop Nov 21, 2024
10 of 11 checks passed
@ofahimIQSS ofahimIQSS deleted the 7239-mydata-results-by-username branch November 21, 2024 19:36
@ofahimIQSS ofahimIQSS removed their assignment Nov 21, 2024
@pdurbin pdurbin added this to the 6.5 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: My Data Feature: Search/Browse Feature: Superuser Dashboard FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) FY25 Sprint 10 FY25 Sprint 10 (2024-11-06 - 2024-11-20) FY25 Sprint 11 FY25 Sprint 11 (2024-11-20 - 2024-12-04) Size: 10 A percentage of a sprint. 7 hours. Type: Bug a defect
Projects
None yet
6 participants