Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch exceptions from DatasetServiceBean.findDeep #10601

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented May 30, 2024

What this PR does / why we need it:

After this pull request was merged...

... tests starting failing (#10599).

This pull request cherry-picks the commit a79cdbf from @luddaniel from PR #10371.

I ran just the failing test locally with mvn test -Dtest=HarvestingServerIT#testSingleRecordOaiSet and it passed on my machine so it seems to be a good fix.

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10599-findDeep
ghcr.io/gdcc/configbaker:10599-findDeep

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Copy link
Collaborator

@ErykKul ErykKul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for causing this...

@ErykKul ErykKul merged commit e6b5856 into develop May 31, 2024
19 checks passed
@jp-tosca jp-tosca deleted the 10599-findDeep branch June 3, 2024 14:41
@pdurbin pdurbin added this to the 6.3 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HarvestingServerIT.testSingleRecordOaiSet failing after PR 9684 was merged
3 participants