Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Faster combined query for retrieving datasets via API" #10600

Closed
wants to merge 1 commit into from
Closed

Revert "Faster combined query for retrieving datasets via API" #10600

wants to merge 1 commit into from

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented May 30, 2024

@github-actions GitHub Actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:revert-9684-9683-get-dataset-api-in-single-query

ghcr.io/gdcc/configbaker:revert-9684-9683-get-dataset-api-in-single-query

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

jp-tosca
jp-tosca approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@jp-tosca jp-tosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 @pdurbin @landreev was asking on slack if there is not a fix for this and if it is necessary to revert. I will approve now but just to double check.

@qqmyers
Copy link
Member

qqmyers commented Jun 1, 2024

Closed in favor of #10601 which has been merged.

@qqmyers qqmyers closed this Jun 1, 2024
@pdurbin pdurbin deleted the revert-9684-9683_get_dataset_api_in_single_query branch June 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp-tosca jp-tosca jp-tosca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HarvestingServerIT.testSingleRecordOaiSet failing after PR 9684 was merged
4 participants
@pdurbin @qqmyers @jp-tosca @stevenwinship