Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ApplicationTermsOfUse API #6862

Closed
Venki18 opened this issue Apr 28, 2020 · 3 comments
Closed

Bug in ApplicationTermsOfUse API #6862

Venki18 opened this issue Apr 28, 2020 · 3 comments

Comments

@Venki18
Copy link

Venki18 commented Apr 28, 2020

I tried to update the ApplicationTermsOfUse API to upload a html file and failed. Followed the instruction provided in the guide.

curl -X PUT -d@/tmp/apptou.html http://localhost:8080/api/admin/settings/:ApplicationTermsOfUse

But when I used the language specific Terms of Use file for English as below and IT WORKED.

curl -X PUT -d@/tmp/apptou.html http://localhost:8080/api/admin/settings/:ApplicationTermsOfUse/lang/en

I think there is a bug in the API.

@pdurbin
Copy link
Member

pdurbin commented Apr 28, 2020

I'm not aware of a bug but there certainly could be. Language support for settings was added in pull request #6042. Perhaps a bug crept in later.

@qqmyers
Copy link
Member

qqmyers commented Aug 12, 2020

Good catch! See #7189 - it looks like your first upload will set the terms for the server's defaultLocale/language, but any visitors using a different locale/language would see the default from the system.app.terms Bundle.properties entry. The second would set the terms only for people using a locale with the 'en' language.

We're still discussing the best fix but my guess is that any solution will support having a way to set a default for all languages via a setting.

In the meantime, I think the notes in #7189 will help you work-around this issue.

@djbrooke
Copy link
Contributor

Hi @Venki18 - I'm going to close this as I suspect it was fixed in #7189/#7192 in Dataverse 5.

atniph pushed a commit to dsd-sztaki-hu/dataverse that referenced this issue Jul 13, 2023
When a Dataset is published, its corresponding RO-Crate will now be saved as well, using the same version number as the Dataset. When downloading the RO-Crate, the one from the latest published Dataset version will be retrieved, unless it doesn't exist, in which case the RO-Crate for the DRAFT version of the Dataset will be downloaded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants