-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid creating unnecessary tables for Resource and DomainResource resource types #713
Comments
I added an "includeAbstract" boolean argument for |
Robin found the offending lines: https://github.com/IBM/FHIR/blob/main/fhir-persistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/ParameterVisitorBatchDAO.java#L185-L204 It seems to be designed such that search parameter values with a base of |
Question: Should we remove these unneeded tables as part of schema migration? team decision: yes. but we should ensure there is no data in these tables before we delete them. if there is data in these tables somehow, then fail the upgrade. (or finish the upgrade and just log as warning?) Question: what to do with the corresponding entries in FHIR_ADMIN.VERSION_HISTORY ? options: |
bumping to a P2 because, now that we are publishing multiple versions of all us-core and carin-bb search parameters, we get A LOT of warnings (on each request) if those are installed and the user hasn't disambiguated the versions. |
resource types #713 - Checks for DOMAINRESOURCE and RESOURCE tables view - Removes the artifacts - Bonus: added fix for null condition on a code in DefaultMemberMatchStrategy Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
Avoid creating unnecessary tables for Resource and DomainResource resource types #713
verified that the targeted tables are not created in a update-schema, and are removed when issuing an update-schema on an older schema definition. |
Describe the bug
Follow-on from #623
What about Resource_LOGICAL_RESOURCES, DomainResource_LOGICAL_RESOURCES, Resource_RESOURCES, and DomainResource_RESOURCES tables...are we generating those tables? Do we need them?
John tried to remove these, but something must be trying to use it because he saw a ForeignKeyException that he traced back to these missing tables.
To Reproduce
Expected behavior
Abstract resources shouldn't have resource tables.
Additional context
The way its designed, we'd need to special case these somehow. Is there a cleaner way?
The text was updated successfully, but these errors were encountered: