issue 2751 make sure drop schema drops everything #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre
reviewed
Nov 3, 2021
...atabase-utils/src/main/java/com/ibm/fhir/database/utils/postgres/PostgresDoesIndexExist.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/ListTablesDAO.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/SchemaInfoObject.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/SchemaInfoObject.java
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
...-database-utils/src/main/java/com/ibm/fhir/database/utils/db2/Db2ListSequencesForSchema.java
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/db2/Db2ListTablesForSchema.java
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/derby/DerbyAdapter.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
...abase-utils/src/main/java/com/ibm/fhir/database/utils/derby/DerbyListSequencesForSchema.java
Show resolved
Hide resolved
prb112
reviewed
Nov 3, 2021
| + " WHERE LOWER(table_schema) = LOWER('" + schemaName + "') " | ||
| + " AND LOWER(table_name) = LOWER('" + tableName + "')"; | ||
| + " WHERE table_schema = LOWER('" + schemaName + "') " | ||
| + " AND table_name = LOWER('" + tableName + "')"; |
There was a problem hiding this comment.
I think initially our Postgres code allowed upper case input. I know Postgres smacks it to LOWER internally.
Is this truly backwards compatible with our older versions?
Please confirm
There was a problem hiding this comment.
PostgreSQL lower-cases identifiers (like table-names) unless they are quoted (which we don't...because it makes things ugly and unreadable). Also, putting LOWER on the columns in that way prevents use of any indexes which could lead to much worse performance for bigger schemas.
lmsurpre
approved these changes
Nov 3, 2021
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
but really just to force a rebuild... Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robin Arnold robin.arnold@ibm.com
In addition to making sure we clean up the new WHOLE_SYSTEM_VERSION and CONTROL tables, we also now do a final check on the cleaned schema to make sure it is really clean and contains no tables.
The drop is now idempotent (dropping a second time will be a NOP) and if the drop is successful, the VERSION_HISTORY data will be cleared for the dropped schema, allowing the same schema name to be reused immediately.