Issue 1683 and 1955 composite search param schema change and implementation of system history #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
… to retrieve data Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Issue 1683/1955 share dev work to feature branch
…upgrade if table is empty. Addresses issue 1847. Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Issue #1683 - query builder changes for composite search
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Issue 1683 robin merged and fixed broken unit test
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Issue #1683 - wrap log.fine stmts, add testcases
…sub parameter. Change postgres tuning default to 7 based on test results Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Issue 1683 robin
… flag to logical_resources Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
issue 1683 fixed db2 and postgres stored procs. Added 1958 is_deleted…
prb112
reviewed
Feb 27, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/DropPrimaryKey.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
prb112
reviewed
Feb 27, 2021
prb112
reviewed
Feb 27, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/model/CharColumn.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/model/ColumnDefBuilder.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence-schema/src/test/java/com/ibm/fhir/schema/derby/DerbyFhirDatabaseTest.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence-schema/src/test/java/com/ibm/fhir/schema/prior/FhirSchemaGenerator455.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence/src/main/java/com/ibm/fhir/persistence/FHIRPersistence.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence/src/main/java/com/ibm/fhir/persistence/ResourceChangeLogRecord.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence/src/main/java/com/ibm/fhir/persistence/util/FHIRPersistenceUtil.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
...sistence/src/test/java/com/ibm/fhir/persistence/search/test/AbstractSearchCompositeTest.java
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-persistence/src/test/java/com/ibm/fhir/persistence/test/common/AbstractChangesTest.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
fhir-server-test/src/test/java/com/ibm/fhir/server/test/SystemHistoryTest.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Feb 27, 2021
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
…ser guide Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Issue 1683 and 1955 resolved conflicts with main and updated user guide
michaelwschroeder
approved these changes
Mar 1, 2021
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/common/ReorgTable.java
Outdated
Show resolved
Hide resolved
fhir-database-utils/src/main/java/com/ibm/fhir/database/utils/model/CharColumn.java
Show resolved
Hide resolved
...tence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/FetchResourceChangesDAO.java
Show resolved
Hide resolved
...istence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/ResourceTokenValueRec.java
Show resolved
Hide resolved
...rsistence-schema/src/main/java/com/ibm/fhir/schema/control/BackfillResourceChangeLogDb2.java
Outdated
Show resolved
Hide resolved
...rsistence-schema/src/main/java/com/ibm/fhir/schema/control/BackfillResourceChangeLogDb2.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Mar 1, 2021
lmsurpre
reviewed
Mar 1, 2021
...ence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/ParameterVisitorBatchDAO.java
Show resolved
Hide resolved
lmsurpre
reviewed
Mar 1, 2021
...ence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/ParameterVisitorBatchDAO.java
Show resolved
Hide resolved
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
lmsurpre
reviewed
Mar 1, 2021
...istence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/dao/impl/ResourceTokenValueRec.java
Show resolved
Hide resolved
lmsurpre
reviewed
Mar 1, 2021
| /** | ||
| * Utility to create all the tables associated with a particular resource type | ||
| */ | ||
| public class FhirResourceTableGroup455 { |
There was a problem hiding this comment.
It might be a bit cleaner just to download the fhir-persistence-schema cli jar (version 4.5.5) and execute it like an external program
There was a problem hiding this comment.
I had originally put in a placeholder hook in the fhir-persistence-schema's pom.xml for doing just that:
<plugin>
<artifactId>exec-maven-plugin</artifactId>
<version>1.6.0</version>
<groupId>org.codehaus.mojo</groupId>
<executions>
<execution>
<id>deployPriorVersions</id>
<phase>test</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>bash</executable>
<commandlineArgs>deployPriorVersions.sh</commandlineArgs>
</configuration>
</execution>
</executions>
</plugin>
However, at the time the fhir-persistence-schema didn't support the instantiation of derby dbs, and so I had to revert to this pattern where I copy-pasted the old FhirResourceTableGroup into the project as a test dependency.
There was a problem hiding this comment.
Worth discussing, especially if we decide to make a breaking change to our schema model apis. But I do like the idea of the build being standalone and not breaking when some old release gets purged from a repo.
lmsurpre
reviewed
Mar 1, 2021
Comment on lines
+65
to
+66
| // Type of change C - Create, U - Update, S - Soft Delete. H - Hard Delete | ||
| public static final String CHANGE_TYPE = "CHANGE_TYPE"; |
There was a problem hiding this comment.
is this supposed to align with constants in ResourceChangeLogRecord ? I didn't see the distinction between soft delete and hard delete in that one, so wasn't sure if this comment was accurate or not.
There was a problem hiding this comment.
It was a comment for the future when we support hard-delete.
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
issue 1955 use resource subset for all operations in schema tool
lmsurpre
reviewed
Mar 4, 2021
| @@ -419,27 +442,25 @@ public Table addResourceTokenRefs(List<IDatabaseObject> group, String prefix) { | |||
| Table tbl = Table.builder(schemaName, tableName) | |||
| .setVersion(FhirSchemaVersion.V0008.vid()) | |||
There was a problem hiding this comment.
This should have been bumped to V0009 here but we missed it :-(
lmsurpre
added a commit
that referenced
this pull request
Mar 4, 2021
We missed this as part of #1996, so anyone that has applied these updates to a DB since that change now has the wrong version of that object. Since that change was never released, I think we're OK just to fix it now (and help anyone riding the bleeding edge to manually fix their VERSION_HISTORY table). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this pull request
Mar 4, 2021
We missed this as part of #1996, so anyone that has applied these updates to a DB since that change now has the wrong version of that object. Since that change was never released, I think we're OK just to fix it now (and help anyone riding the bleeding edge to manually fix their VERSION_HISTORY table). Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.