Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Cloud-Databases): Revert "Add version validation (#5791)" #5859

Merged

Conversation

lornakelly
Copy link
Contributor

@lornakelly lornakelly commented Dec 9, 2024

This reverts commit f542550.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Reverts this PR that is causing issues
#5791

Output from acceptance testing:

$  make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseInstance_Redis_Basic'
=== RUN   TestAccIBMDatabaseInstance_Redis_Basic
=== PAUSE TestAccIBMDatabaseInstance_Redis_Basic
=== CONT  TestAccIBMDatabaseInstance_Redis_Basic
--- PASS: TestAccIBMDatabaseInstance_Redis_Basic (1242.09s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1245.936s

Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omaraibrahim omaraibrahim merged commit 8d3fab4 into IBM-Cloud:master Dec 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants