Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version validation #5791

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Add version validation #5791

merged 1 commit into from
Nov 15, 2024

Conversation

lornakelly
Copy link
Contributor

@lornakelly lornakelly commented Nov 14, 2024 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

https://github.ibm.com/compose/App/issues/1523

  • Remove force new when version changes
  • Validate the version on plan
  • Notify customer they should update version to match remote

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Example of when db is changed on IBM side
Screenshot 2024-11-12 at 13 54 34

Example of user trying to update minor version
Screenshot 2024-11-12 at 13 54 52

Example of user trying to update major version
Screenshot 2024-11-12 at 13 55 07

omaraibrahim
omaraibrahim approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omaraibrahim omaraibrahim merged commit f542550 into IBM-Cloud:master Nov 15, 2024
1 check passed
@lra lra mentioned this pull request Dec 9, 2024
Closed
lornakelly pushed a commit to lornakelly/terraform-provider-ibm that referenced this pull request Dec 9, 2024
Revert "Add version validation (IBM-Cloud#5791)"
1f746b4 
This reverts commit f542550.
@lornakelly lornakelly mentioned this pull request Dec 9, 2024
Merged
omaraibrahim pushed a commit that referenced this pull request Dec 9, 2024
@lornakelly
Revert "Add version validation (#5791)" (#5859)
8d3fab4 
This reverts commit f542550.

Co-authored-by: Lorna-Kelly <lorna.kelly@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaraibrahim omaraibrahim omaraibrahim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lornakelly @omaraibrahim