Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Reintroduce webview for submitting transactions on v2 #2642

Merged

Conversation

erin-hughes
Copy link
Contributor

@erin-hughes erin-hughes commented Sep 18, 2020

This is mostly tidying up and reintegrating the transaction view - you should be able to submit & evaluate transactions using it again. To try it out, go into the package.json and remove these lines:

{
     "command": "transactionPage.open",
     "when": "false"
},

Contributes to #1155

Signed-off-by: Erin Hughes Erin.Hughes@ibm.com

@mergify
Copy link
Contributor

mergify bot commented Sep 18, 2020

Please speak to the engagement team regarding updating tutorial & screenshots if any UI changes have been made!

Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
Copy link
Contributor

@james-wallis james-wallis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the view makes it a lot easier to make transactions.

@sonarcloud
Copy link

sonarcloud bot commented Oct 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@erin-hughes erin-hughes merged commit 0dc7b26 into IBM-Blockchain:v2 Oct 2, 2020
@erin-hughes erin-hughes deleted the revive-transaction-view-v2 branch October 2, 2020 13:57
erin-hughes added a commit to erin-hughes/blockchain-vscode-extension that referenced this pull request Oct 7, 2020
Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
Jakeeyturner added a commit that referenced this pull request Oct 8, 2020
Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>

Co-authored-by: Jake <10009752+Jakeeyturner@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants