improve submit transaction

[cazfletch]

Submitting a transaction is ok if you just have strings as parameters but it is not ideal if you have objects especially if they are large objects. We should provide a way of submitting a transaction more easily with objects. It would also be good to be able to repeatedly submit transactions without having to go through the process of typing in the parameters again.

[EdMoffatt]

Another one for you Charlotte. I think Andy Hurt or Liam Grace would be good folks to explain to you what's needed here :) Similar plan to the events one, do some research, come up with some suggestions, and then let's review both of them in one meeting with the VS Code squad 👍

[awjh-ibm]

Would be great if my previous inputs were selectable below (in the style of the selecting a function) and also if the form could tell me the arg names not just to enter arg0 etc

[Charlotte8699]

Transaction web view update

This is the latest click through of the transactions:
https://xd.adobe.com/view/7b0c6b7e-21b5-46fa-64d7-14b5d4c17091-0d3d/

I've since had further feedback from Liam which I'll be acting on today/tomorrow. I have also been working with @erin-hughes to find out what i need to be doing to make creating this web view easier for her.

[EdMoffatt]

Great progress on this @Charlotte8699 . I wonder how it would look without the twisties in the "Recent" view? I think a permanently displayed table could work here, with new transactions appearing at the top - collapsing by date doesn't seem to add much to me!

[awjh-ibm]

Has any thought been put into how i might run this using keyboard shortcuts? Ideally I would like to look at my code whilst I run the command. I usually do most of my repeatable transactions when i am in debug mode and like to stay on the same code page so I can view the values in variables as it goes through breakpoints.

The current method of runnign transactions is nice as I can do it entirely from my keyboard. CMD+L I have configured to bring up the Evaluate vs Submit options and can then use arrow keys and enter to select the transaction and run it.

[Charlotte8699]

Latest development - deleting the date filter, showing how the filters would work and switching between the alternatives for entering in arguments.
Let me know what you think!

https://xd.adobe.com/view/52870c3d-9c4c-47ef-7312-798420c1556b-24b6/

@awjh I have thought briefly how shortcuts could be included but as of yet, i haven't put too much thought into it. I'll come find you, Caroline, Jake etc. once we've settled on the layout to plan how commands could be used. I'll put time into this next week!

[cazfletch]

I don't think you would want the alternatives for arguments as you don't have key value pairs for arguments, this would work for transient data though.

[Jakeeyturner]

With the work happening in #1510, we'll also need to be able to handle peer-targeting in the new transaction page.

[Charlotte8699]

Update on the transactions - I've started looking at spacing more closely and added in the section on targeting a peer. I've split the transient data into key/value instead of arguments as well.

[Charlotte8699]

Changed the format for the custom peers and adjusted the wording on the filters. Hoping to get a flow for this done today.
Please let me know what you think!
@Jakeeyturner @cazfletch @EdMoffatt @erin-hughes @liam-grace

[Charlotte8699]

Created a flow for when a user would create a transaction, save a transaction and then use the filters. If there are other flows people would like to see, let me know.

@sstone1 Ed recommended I show you this.
https://xd.adobe.com/view/e9fb7327-3b80-4c8d-7b8e-e99976027cdb-9fca/

[cazfletch]

@Charlotte8699 i noticed that export was only on a saved one, just wondered if users might also want to export on none saved ones? I can see an argument for both sides though.

Can we get a flow for import, i remember us talking about that i wasn't sure how it would work

[Charlotte8699]

I've created a mock up for importing and exporting transactions here
https://xd.adobe.com/view/cd15fd26-5440-47b6-5924-64e0b4a17558-bb24/

I was thinking of not making it possible to export non saved transactions - as transactions will have to have a copy saved to be exported to another user anyway.
The format of this export/import is still to be determined. I'll speak to @sstone1 today after retro today.

[Charlotte8699]

I had a feedback session with @EdMoffatt and Shaun yesterday and they gave some helpful feedback. Lots of words incoming!

Summary
The home page and filters have had some slight phrasing changes

• 'Create a new transaction' has become 'Submit/evaluate a transaction'
• I have deleted the filter for controlling how many transactions are shown in the history
• The output will automatically be on
• Some information has been put in about what gateway the user is in (Local Fabric)

Home page

The main thing that came up to clarify would be the behaviour of saving transactions

https://xd.adobe.com/view/8cb597b2-97c5-474b-4463-c1971452eb80-fa84/

Recap on saving transactions

• Transaction is saved

Scenario 1 - Submitting changes to saved transaction without saving the changes

• Change arguments
• Submit transaction with no change to time stamp for saved transaction as the changes haven't been saved
• New transaction added to recent

Scenario 2 - User changes info and saves without submitting

• Name and args change
• Transaction saves and updates the transaction time stamp
• No transaction added to recent as nothing has been submitted/evaluated

Scenario 3 - User makes changes and doesn't save/submit

• User makes changes to transaction
• Visits homepage without saving or submitting
• Returns to transaction to see that none of the changes have been saved

@cazfletch Is the ability to add more than one set of both arguments and transient data useful?

If so, would the current layout be better - so adding sets of transient data and arguments individually.

Or, would dividing the transient data and arguments up into sets - so they come in pairs like this.

[cazfletch]

I don't think having sets of arguments is useful, i think if you would save multiple transactions in that case with the different arguments

[Charlotte8699]

No problem, i've deleted that feature. I haven't redone the flows above as the saved interactions won't be affected by this.

[Charlotte8699]

Lots of great feedback from Joe Payne and Tom Appleyard!

• They would like to be able to enter multiple sets of arguments for 1 transaction rather than submit multiple transactions of the same type.
• Have a warning with the arguments box that states whatever is entered will be 'stringified'.
• Have argument box as 1 line with the ability to expand it should the argument take up more than 1 line (they mentioned the phrase 'mono spacing', I assume this means each line has a set spacing where the box increases incrementally). Also having a preview for the arguments and transient data.
• Transient data could take a table type format
• Be able to group peers and target private data collections (something that could be done in advanced options)
• The tabs for recent and saved look like they are headings for the transaction name and time stamp
• Add notification to confirm transaction has saved
• Submit/evaluate phrasing: take it back to 'create new transaction'. Although this does sound like creating a new type of transaction, because of the context it is better than 'submit/evaluate transaction' as it looks like you're about to resubmit an existing transaction.
• Evaluate/submit buttons should be under the form
• Have a button for resubmitting last transaction
• Need to get example of output to format this properly: e.g. dividing the output into HTTP code and resulting json as they would like to be able to copy this output to be used in future transactions
• Have output filter as the output will likely be big for each transaction; able to find specific piece of info like 'HTTP code'
• Show result of each peer after transaction: if certain peers should be rejecting the transaction because they're not in the targeted pdc, this would be useful to see.

I'll start acting on this on Monday.

[Charlotte8699]

An update on how the hi fis are coming along.

• The 'remove set' next to set 1 is just a reminder to add it in for set 2, the user wont be able to remove set 1.
• Still unsure where to put 'switch smart contract'
• Transaction output will be changed to get rid of the 'show less' and 'copy' buttons, it will just be an area you can scroll on.

Any comments are welcome!

[Charlotte8699]

The latest styling of the transactions view

The view has now been split up into tabs to make the page more customisable for the user - the tabs can be resized/opened/closed based on what the user would like to see. I am presently updating the flows with the latest feedback from the dev team.

[Jakeeyturner]

Closing - this works has been completed.