This repository has been archived by the owner on Jan 31, 2023. It is now read-only.
[do not merge] Adding submit functionality to the transaction view #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erin-hughes
force-pushed
the
submit-txn-1486
branch
4 times, most recently
from
091cf18
to
e0f4c35
Compare
erin-hughes
force-pushed
the
submit-txn-1486
branch
from
e0f4c35
to
6e8e3fa
Compare
| getTransactionArgumentsSpy.should.have.been.called; | ||
| expect(component.state().transactionArguments).toBe('name: \n'); | ||
| expect(component.state().activeTransaction).toBe(transactionOne); |
There was a problem hiding this comment.
I've only just noticed this - I think we should be using the should syntax like we do everywhere else instead of expect.
src/App.tsx
Outdated
| this.setState({ | ||
| childState: { | ||
| activeSmartContract: this.state.childState.smartContracts.filter((obj: ISmartContract) => obj.label === newActiveContractLabel)[0], | ||
| smartContracts: this.state.childState.smartContracts | ||
| activeSmartContract: smartContracts.filter((obj: ISmartContract) => obj.label === newActiveContractLabel)[0], |
There was a problem hiding this comment.
smartContracts.filter((obj: ISmartContract) => obj.label === newActiveContractLabel)[0] can be written as:
smartContracts.find((obj: ISmartContract) => obj.label === newActiveContractLabel)
Signed-off-by: Erin Hughes <Erin.Hughes@ibm.com>
erin-hughes
force-pushed
the
submit-txn-1486
branch
from
6e8e3fa
to
7a958df
Compare
erin-hughes
changed the title
|
Closing as the merge with the mono repo changes was too messy Opened a fresh PR instead (#1674 ) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1486 and contributes to #1155
Signed-off-by: Erin Hughes Erin.Hughes@ibm.com