Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DIA-1748: 'Generate labels with AI' button in Project, in SC #43

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: DIA-1748: 'Generate labels with AI' button in Project, in SC #43

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
57af2f1
feat: DIA-1748: Add API schema def for product tour and in projects
Dec 20, 2024
6ac2164
add JSF def for LabelInterface in SDK
matt-bernstein Dec 20, 2024
794dc8a
bump numpy version
matt-bernstein Dec 20, 2024
1d94cac
Merge remote-tracking branch 'origin/master' into fb-dia-1748
farioas Dec 20, 2024
704bbaa
Set pyproject_python_version
nikitabelonogov Dec 20, 2024
b134779
ci: Upgrade fern version
nikitabelonogov Dec 20, 2024
34f5125
ad jsf
nikitabelonogov Dec 20, 2024
e2c6b41
Revert "ci: Bump fern version (#44)"
nikitabelonogov Dec 20, 2024
8fdf8ce
revert fernapi/fern-python-sdk
nikitabelonogov Dec 20, 2024
45ce14b
Merge branch 'fb-fern-upgrade' into fb-dia-1748
nikitabelonogov Dec 20, 2024
fc5dde6
bump to 3.10
farioas Dec 24, 2024
089ff9e
uograde fern
farioas Dec 24, 2024
4f3ff96
downgrade python
farioas Dec 24, 2024
af1cd00
Revert generators version
Dec 25, 2024
c0d8e82
prompt -> prompts
Dec 25, 2024
dd159a3
Add comment about audiences
Dec 25, 2024
33b163b
Merge branch 'master' into fb-dia-1748
niklub Dec 25, 2024
8c0cb9a
ModelRun.model_version must be integer
Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion fern/generators.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ groups:
xmljson: '0.2.1'
jsonschema: '>=4.23.0'
requests-mock: '1.12.1'
numpy: '<2.0.0'
numpy: '^1.26.4'
datamodel-code-generator: '0.26.1'
jsf: '^0.11.2'
# scikit-learn: '1.5.1'
smart-casing: true
python-sdk-local:
Expand Down
3 changes: 3 additions & 0 deletions fern/openapi/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8982,6 +8982,9 @@ components:
title: Organization
type: integer
nullable: true
prompt:
$ref: "#/components/schemas/Prompt"
nullable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think we need to have a product discussion about baking in the assumption 1 project == 1 prompt so deeply, but it's fine for now, since we're all familiar enough with the codebase. Our data models can support many to many, and for testing at least it's very common ime to create many prompts for the same project, but if you didn't know that, it'd be easy to lose track of the extra prompts and introduce bugs that way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with this more generic approach: added a support multiple prompts instead a single prompt case on the API level, and by handling special case with the first prompt only in the current UI instead.

color:
title: Color
type: string
Expand Down
14 changes: 14 additions & 0 deletions fern/openapi/overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
paths:
/api/current-user/product-tour:
get:
$ref: "./resources/users.yaml#/paths/~1api~1current-user~1product-tour/get"
x-fern-sdk-group-name: users
x-fern-sdk-method-name: get_product_tour
x-fern-audiences:
- internal
patch:
$ref: "./resources/users.yaml#/paths/~1api~1current-user~1product-tour/patch"
x-fern-sdk-group-name: users
x-fern-sdk-method-name: update_product_tour
x-fern-audiences:
- internal

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about x-fern-audiences, it looks like this only defines the group and doesn't do anything unless there is logic elsewhere to tell if a user is internal or not. Is that true? Setup to do this in future? Maybe leave a comment about it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

/api/prompts/:
get:
$ref: "./resources/prompts.yaml#/paths/~1api~1prompts/get"
Expand Down
Loading