-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: DIA-1748: 'Generate labels with AI' button in Project, in SC #43
base: master
Are you sure you want to change the base?
Conversation
Follow Merge downstream workflow has been failed. |
fern/openapi/openapi.yaml
Outdated
prompt: | ||
$ref: "#/components/schemas/Prompt" | ||
nullable: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we need to have a product discussion about baking in the assumption 1 project == 1 prompt so deeply, but it's fine for now, since we're all familiar enough with the codebase. Our data models can support many to many, and for testing at least it's very common ime to create many prompts for the same project, but if you didn't know that, it'd be easy to lose track of the extra prompts and introduce bugs that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with this more generic approach: added a support multiple prompts
instead a single prompt
case on the API level, and by handling special case with the first prompt only in the current UI instead.
fern/openapi/overrides.yaml
Outdated
/api/current-user/product-tour: | ||
get: | ||
$ref: "./resources/users.yaml#/paths/~1api~1current-user~1product-tour/get" | ||
x-fern-sdk-group-name: users | ||
x-fern-sdk-method-name: get_product_tour | ||
x-fern-audiences: | ||
- internal | ||
patch: | ||
$ref: "./resources/users.yaml#/paths/~1api~1current-user~1product-tour/patch" | ||
x-fern-sdk-group-name: users | ||
x-fern-sdk-method-name: update_product_tour | ||
x-fern-audiences: | ||
- internal | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about x-fern-audiences, it looks like this only defines the group and doesn't do anything unless there is logic elsewhere to tell if a user is internal or not. Is that true? Setup to do this in future? Maybe leave a comment about it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
Follow Merge downstream workflow has been failed. |
1 similar comment
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
fern/generators.yml
Outdated
@@ -10,7 +10,7 @@ groups: | |||
- public | |||
generators: | |||
- name: fernapi/fern-python-sdk | |||
version: 4.3.10 | |||
version: 2.14.0-rc0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
? why 2 major releases backwards??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, some weird merge conflict, fixed
fern/generators.yml
Outdated
# scikit-learn: '1.5.1' | ||
smart-casing: true | ||
python-sdk-local: | ||
audiences: | ||
- public | ||
generators: | ||
- name: fernapi/fern-python-sdk | ||
version: 4.3.10 | ||
version: 3.10.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, confused on version change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
Follow Merge downstream workflow has been failed. |
No description provided.