refactor: remove JQuery from parts of Search JS #2970
Conversation
✅ Deploy Preview for hugo-portfolio-theme canceled.
|
✅ Deploy Preview for academic-demo canceled.
|
✅ Deploy Preview for markdown-slides canceled.
|
| document.querySelector('#TableOfContents').classList.add('nav flex-column'); | ||
| } | ||
| if (document.querySelector('#TableOfContents li')) { | ||
| document.querySelector('#TableOfContents li').classList.add('nav-item'); |
There was a problem hiding this comment.
There can be multiple <li>, so surely this requires a foreach statement?
Similar feedback applies to the other instances where the query selector matches multiple elements.
There was a problem hiding this comment.
Have you tested all these changes?
There was a problem hiding this comment.
@Konafets I see you have pushed some more changes but have not responded to the above comments yet?
Do the new commits fix all the issues and have you now tested that the PR works?
There was a problem hiding this comment.
Hi,
yes after your question I get back and tested all changes successfully. This means, multiple tables are handled correctly, the table of content and the checkboxes get the bullets removed. From my tests, it works like it did before.
Konafets
force-pushed
the
remove_jquery
branch
2 times, most recently
from
bc6ff79
to
02083a9
Compare
gcushen
changed the title
Towards achieving #1402