Remove some low hanging JQuery fruits

Related #1402
HugoBlox · Aug 2, 2023 · 6fda882 · 6fda882
1 parent 1c09422
commit 6fda882
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 20 deletions.
diff --git a/modules/wowchemy/assets/js/algolia-search.js b/modules/wowchemy/assets/js/algolia-search.js
@@ -42,7 +42,7 @@ function getSearchQuery(name) {
 document.addEventListener('DOMContentLoaded', () => {
   let queryURL = getSearchQuery('q');
   if (queryURL) {
-    $('body').addClass('searching');
+    document.querySelector('body').classList.add('searching');
     $('.search-results').css({opacity: 0, visibility: 'visible'}).animate({opacity: 1}, 200);
     let commonQueries = document.querySelector('#search-common-queries');
 

diff --git a/modules/wowchemy/assets/js/wowchemy-navigation.js b/modules/wowchemy/assets/js/wowchemy-navigation.js
@@ -29,14 +29,14 @@ function scrollToAnchor(target, duration = 0) {
     target = '#' + $.escapeSelector(target.substring(1)); // Previously, `target = target.replace(/:/g, '\\:');`
 
     let elementOffset = Math.ceil($(target).offset().top - getNavBarHeight()); // Round up to highlight right ID!
-    $('body').addClass('scrolling');
+    document.querySelector('body').classList.add('scrolling');
     $('html, body').animate(
       {
         scrollTop: elementOffset,
       },
       duration,
       function () {
-        $('body').removeClass('scrolling');
+        document.querySelector('body').classList.remove('scrolling');
       },
     );
   } else {

diff --git a/modules/wowchemy/assets/js/wowchemy-search.js b/modules/wowchemy/assets/js/wowchemy-search.js
@@ -181,7 +181,7 @@ if (typeof Fuse === 'function') {
     // On page load, check for search query in URL.
     let query = getSearchQuery('q');
     if (query) {
-      $('body').addClass('searching');
+      document.querySelector('body').classList.add('searching');
       $('.search-results').css({opacity: 0, visibility: 'visible'}).animate({opacity: 1}, 200);
       $('#search-query').val(query);
       $('#search-query').focus();

diff --git a/modules/wowchemy/assets/js/wowchemy.js b/modules/wowchemy/assets/js/wowchemy.js
@@ -32,10 +32,11 @@ function removeQueryParamsFromUrl() {
  * --------------------------------------------------------------------------- */
 
 function toggleSearchDialog() {
-  if ($('body').hasClass('searching')) {
+  const body = document.querySelector('body');
+  if (body.classList.contains('searching')) {
     // Clear search query and hide search modal.
-    $('[id=search-query]').blur();
-    $('body').removeClass('searching compensate-for-scrollbar');
+    document.querySelector('[id=search-query]').blur();
+    body.classList.remove('searching', 'compensate-for-scrollbar');
 
     // Remove search query params from URL as user has finished searching.
     removeQueryParamsFromUrl();
@@ -50,17 +51,20 @@ function toggleSearchDialog() {
           (window.innerWidth - document.documentElement.clientWidth) +
           'px;}</style>',
       );
-      $('body').addClass('compensate-for-scrollbar');
+      body.classList.add('compensate-for-scrollbar');
     }
 
     // Show search modal.
-    $('body').addClass('searching');
+    body.classList.add('searching');
+
+    // I assume that is broken
     $('.search-results').css({opacity: 0, visibility: 'visible'}).animate({opacity: 1}, 200);
+
     let algoliaSearchBox = document.querySelector('.ais-SearchBox-input');
     if (algoliaSearchBox) {
       algoliaSearchBox.focus();
     } else {
-      $('#search-query').focus();
+      document.getElementById('search-query').focus();
     }
   }
 }
@@ -75,15 +79,25 @@ function toggleSearchDialog() {
 function fixHugoOutput() {
   // Fix Goldmark table of contents.
   // - Must be performed prior to initializing ScrollSpy.
-  $('#TableOfContents').addClass('nav flex-column');
-  $('#TableOfContents li').addClass('nav-item');
-  $('#TableOfContents li a').addClass('nav-link');
+  if (document.querySelector('#TableOfContents')) {
+      document.querySelector('#TableOfContents').classList.add('nav flex-column');
+  }
+  if (document.querySelector('#TableOfContents li')) {
+      document.querySelector('#TableOfContents li').classList.add('nav-item');
+  }
+  if (document.querySelector('#TableOfContents li a')) {
+      document.querySelector('#TableOfContents li a').classList.add('nav-link');
+  }
 
   // Fix Goldmark task lists (remove bullet points).
-  $("input[type='checkbox'][disabled]").parents('ul').addClass('task-list');
+  if (document.querySelector('input[type=\'checkbox\'][disabled]')) {
+    document.querySelector('input[type=\'checkbox\'][disabled]').closest('ul').classList.add('task-list');
+  }
 
   // Bootstrap table style is opt-in and Goldmark doesn't add it.
-  $('table').addClass('table');
+  if (document.querySelector('table')) {
+      document.querySelector('table').classList.add('table');
+  }
 }
 
 // Get an element's siblings.
@@ -123,7 +137,7 @@ document.addEventListener('DOMContentLoaded', function () {
  * On window loaded.
  * --------------------------------------------------------------------------- */
 
-$(window).on('load', function () {
+window.addEventListener('load', function () {
   // Re-initialize Scrollspy with dynamic navbar height offset.
   fixScrollspy();
 
@@ -263,10 +277,12 @@ $(window).on('load', function () {
   // Check that built-in search or Algolia enabled.
   if (searchEnabled) {
     // On search icon click toggle search dialog.
-    $('.js-search').click(function (e) {
-      e.preventDefault();
-      toggleSearchDialog();
-    });
+    document.querySelectorAll('.js-search').forEach((element) => {
+      element.addEventListener('click', (e) => {
+        e.preventDefault();
+        toggleSearchDialog();
+      });
+    })
   }
 
   // Init. author notes (tooltips).