-
-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghc 8.10.3 #67284
ghc 8.10.3 #67284
Conversation
9971dad
to
0376987
Compare
0376987
to
e7b7346
Compare
Rebased against master to incorporate fix for |
Adga build failed because the bound of transformers is too tight, and fixed in upstream |
Thanks. Would you know if any of the other builds are failing because of version specifications that are unnecessarily strict? |
I roughly browse the error messages, it seems that is the only one error cause by too strict version bound. |
elm failed with weird error message, I guess it causes by cabal-install. I will investigate it later. |
e7b7346
to
d755d99
Compare
11.0:
10.15:
10.14:
|
Because they are using wrong ghc version: |
Good catch. I should've checked that. What is the correct |
Stack doesn't support ghc 8.10.3, currently commercialhaskell/stack#5463. |
That's annoying. I suppose it doesn't help to let |
Yes, what we can do is waiting for a new stackage snapshot with ghc 8.10.3 support :( |
How difficult would it be to switch Tagging @simonmichael, who might have ideas on how to get |
d755d99
to
a8e9724
Compare
@carlcab thanks for working on this. I can switch hledger back to cabal but I would prefer not to; I switched to stack to fix CI failures with cabal. Once ghc-8.10.3 is available in homebrew, I can make the hledger formula use it, without waiting for a new stackage snapshot. But is there a chicken and egg problem here ? ghc can't be updated unless hledger builds, and it's not easy to temporarily disable the hledger formula ? I'll go ahead and make this update so that possibly both can be merged at the same time. |
Yes, please open a PR to fix |
44c7fdd5 pushed [to #66599], it might work when combined with this PR. |
a8e9724
to
78835a3
Compare
@carlocab please try 5d7c609418, which uses the old cabal build method. |
The old cabal build method has been disabled, so you can no longer use it, unfortunately. |
Oh dear. Meaning, I should use cabal v2-install like in git-annex.rb ? I assumed brew's cabal-install (3.2) is new enough so that "install" is equivalent to "v2-install", but perhaps there's more to it and testing would take a while. I'll pursue this when I can. Is hledger is the only blocker here ? If there's a way to disable it temporarily without actually removing hledger.rb, I'd be fine with that. |
Yes.
There is, but not much more. The issue is that the old |
a8f98fd
to
c2e493c
Compare
Ok, dropped With any luck, the only CI error from the next run should be just If this is the case then I intend to merge this PR as is, since |
Sorry, I've killed CI because we couldn't have used to bottles on Big Sur anyway, due to #67713 You'll need to rebase on top of master and push to start it again |
Yes, I was expecting that. I actually wanted to ping you here to check, but I figured you were busy fighting fires elsewhere and it could wait. Rebasing against master. |
- update build dependency to latest ghc
Patch taken from agda/agda@76278c2
c2e493c
to
963220b
Compare
The kids, mostly 😸 |
@fishtreesugar looks like |
@carlocab Still not show on https://www.stackage.org |
That's annoying. I wonder if this setting help: https://docs.haskellstack.org/en/stable/yaml_configuration/#allow-newer |
If it failed at compiler version checking, try below config may help. system-ghc: true
resolver: nightly-2020-12-14
compiler: ghc-8.10.3
compiler-check: newer-minor |
Right, there isn't a new stackage snapshot tested with GHC 8.10.3 yet, but stack now has the ability to build with GHC 8.10.3 at least. Let's see if efb0f42 at #66599 succeeds. |
Created with
brew bump-formula-pr
.resource
blocks may require updates.