Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghc 8.10.3 #67284

Closed
wants to merge 6 commits into from
Closed

ghc 8.10.3 #67284

wants to merge 6 commits into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 20, 2020

Created with brew bump-formula-pr.

resource blocks may require updates.

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Dec 20, 2020
@carlocab carlocab mentioned this pull request Dec 20, 2020
This was referenced Dec 20, 2020
@carlocab
Copy link
Member Author

Rebased against master to incorporate fix for allureofthestars (#67259).

@fishtreesugar
Copy link
Contributor

Adga build failed because the bound of transformers is too tight, and fixed in upstream

@carlocab
Copy link
Member Author

carlocab commented Dec 21, 2020

Thanks. Would you know if any of the other builds are failing because of version specifications that are unnecessarily strict?

@SeekingMeaning SeekingMeaning mentioned this pull request Dec 21, 2020
2 tasks
@fishtreesugar
Copy link
Contributor

fishtreesugar commented Dec 21, 2020

Thanks. Would you know if any of the other builds are failing because of version specifications that are unnecessarily strict?

I roughly browse the error messages, it seems that is the only one error cause by too strict version bound.

@fishtreesugar
Copy link
Contributor

fishtreesugar commented Dec 21, 2020

Last 150 lines from /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/logs/elm/02.cabal:
2020-12-21 02:52:37 +0000

cabal
v2-install
--jobs=6
--max-backjumps=100000
--install-method=copy
--installdir=/usr/local/Cellar/elm/0.19.1/bin

cabal: Invalid package ID: .

elm failed with weird error message, I guess it causes by cabal-install. I will investigate it later.

@fishtreesugar
Copy link
Contributor

@carlocab carlocab I patched the elm formula #67404, you can give it a try.

@SeekingMeaning
Copy link
Contributor

SeekingMeaning commented Dec 22, 2020

11.0:

brew linkage --test allureofthestars
brew install --build-from-source elm
brew install --build-from-source jupyterlab
brew fetch --retry youtube-dlc
brew install --verbose --build-bottle git-annex
brew install --verbose --build-bottle hledger

10.15:

brew linkage --test allureofthestars
brew install --build-from-source bond
brew install --build-from-source elm
brew fetch --retry youtube-dlc

10.14:

brew linkage --test allureofthestars
brew install --build-from-source bond
brew install --build-from-source elm
brew fetch --retry youtube-dlc

@fishtreesugar
Copy link
Contributor

fishtreesugar commented Dec 23, 2020

git-annex and hledger still failed with:

can't load framework: Cocoa (not found)

Because they are using wrong ghc version: git-annex build dependency still require ghc@8.6 and hledger use stack with lts-16.25 snapshot which ghc version is 8.8.4

@carlocab
Copy link
Member Author

Good catch. I should've checked that. What is the correct resolver to use for hledger so that it uses ghc 8.10.3?

@fishtreesugar
Copy link
Contributor

Good catch. I should've checked that. What is the correct resolver to use for hledger so that it uses ghc 8.10.3?

Stack doesn't support ghc 8.10.3, currently commercialhaskell/stack#5463.

@carlocab
Copy link
Member Author

That's annoying. I suppose it doesn't help to let stack just vendor its own ghc for the build? I suspect that that runs into similar Big Sur incompatibility issues. Not to mention that Homebrew stack is outdated.

@fishtreesugar
Copy link
Contributor

I suppose it doesn't help to let stack just vendor its own ghc for the build?

Yes, what we can do is waiting for a new stackage snapshot with ghc 8.10.3 support :(

@carlocab
Copy link
Member Author

How difficult would it be to switch hledger to a vanilla cabal v2-install?

Tagging @simonmichael, who might have ideas on how to get hledger to build with ghc 8.10.3.

@simonmichael
Copy link
Contributor

simonmichael commented Dec 23, 2020

@carlcab thanks for working on this. I can switch hledger back to cabal but I would prefer not to; I switched to stack to fix CI failures with cabal.

Once ghc-8.10.3 is available in homebrew, I can make the hledger formula use it, without waiting for a new stackage snapshot. But is there a chicken and egg problem here ? ghc can't be updated unless hledger builds, and it's not easy to temporarily disable the hledger formula ? I'll go ahead and make this update so that possibly both can be merged at the same time.

@carlocab
Copy link
Member Author

Yes, please open a PR to fix hledger for ghc 8.10.3. That will make it easy for me to add your commit fixing hledger to this one.

@simonmichael
Copy link
Contributor

simonmichael commented Dec 23, 2020

44c7fdd5 pushed [to #66599], it might work when combined with this PR.

@simonmichael
Copy link
Contributor

@carlocab please try 5d7c609418, which uses the old cabal build method.

@carlocab
Copy link
Member Author

The old cabal build method has been disabled, so you can no longer use it, unfortunately.

@simonmichael
Copy link
Contributor

Oh dear. Meaning, I should use cabal v2-install like in git-annex.rb ? I assumed brew's cabal-install (3.2) is new enough so that "install" is equivalent to "v2-install", but perhaps there's more to it and testing would take a while. I'll pursue this when I can. Is hledger is the only blocker here ? If there's a way to disable it temporarily without actually removing hledger.rb, I'd be fine with that.

@carlocab
Copy link
Member Author

I should use cabal v2-install like in git-annex.rb

Yes.

there's more to it

There is, but not much more. The issue is that the old hledger formula used a special method called install_cabal_package, which no longer exists. You may wish to look at agda to see how I tried to get around it. (I may have done it wrong, tbh; I don't really know how to use cabal. However, it works.)

@carlocab
Copy link
Member Author

carlocab commented Dec 26, 2020

Ok, dropped hledger from this PR.

With any luck, the only CI error from the next run should be just hledger on Big Sur (and possibly a whole lot of failures on the ARM runner if that's active now).

If this is the case then I intend to merge this PR as is, since hledger doesn't have any Big Sur bottles anyway. #65000 (Someone please warn me if that's a mistake.)

@fxcoudert
Copy link
Member

Sorry, I've killed CI because we couldn't have used to bottles on Big Sur anyway, due to #67713

You'll need to rebase on top of master and push to start it again

@carlocab
Copy link
Member Author

Yes, I was expecting that. I actually wanted to ping you here to check, but I figured you were busy fighting fires elsewhere and it could wait. Rebasing against master.

@fxcoudert
Copy link
Member

I figured you were busy fighting fires elsewhere

The kids, mostly 😸

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@carlocab carlocab deleted the bump-ghc-8.10.3 branch December 27, 2020 12:30
@carlocab
Copy link
Member Author

@fishtreesugar looks like haskell-stack now supports ghc 8.10.3: commercialhaskell/stackage-content@812b7e6

@fishtreesugar
Copy link
Contributor

@carlocab Still not show on https://www.stackage.org

@carlocab
Copy link
Member Author

That's annoying. I wonder if this setting help: https://docs.haskellstack.org/en/stable/yaml_configuration/#allow-newer

@fishtreesugar
Copy link
Contributor

If it failed at compiler version checking, try below config may help.

system-ghc: true
resolver: nightly-2020-12-14
compiler: ghc-8.10.3
compiler-check: newer-minor

@simonmichael
Copy link
Contributor

Right, there isn't a new stackage snapshot tested with GHC 8.10.3 yet, but stack now has the ability to build with GHC 8.10.3 at least. Let's see if efb0f42 at #66599 succeeds.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants