Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hledger 1.20 #66599

Closed
wants to merge 2 commits into from
Closed

hledger 1.20 #66599

wants to merge 2 commits into from

Conversation

simonmichael
Copy link
Contributor

Update to hledger 1.20. Also,

  • use hledger-web's built-in tests
  • build with a newer stackage snapshot.

@BrewTestBot BrewTestBot added the haskell Haskell use is a significant feature of the PR or issue label Dec 9, 2020
@simonmichael simonmichael marked this pull request as ready for review December 9, 2020 21:27
carlocab
carlocab reviewed Dec 9, 2020
View reviewed changes
Formula/hledger.rb Outdated Show resolved Hide resolved
@carlocab

This comment has been minimized.

Sign in to view
@chenrui333
Copy link
Member

should be good now for the PR build.

@chenrui333 chenrui333 added 11 Big Sur is specifically affected build failure CI fails while building the software labels Dec 10, 2020
@chenrui333
Copy link
Member

only failed on 11.0 now.

@carlocab
Copy link
Member

carlocab commented Dec 10, 2020 •
edited
Loading

Build error:

--  While building package hledger-ui-1.20 using:
      /private/tmp/hledger-20201210-36773-j90789/hledger-1.20/.brew_home/.stack/setup-exe-cache/x86_64-osx/Cabal-simple_mPHDZzAJ_3.0.1.0_ghc-8.8.4 --builddir=.stack-work/dist/x86_64-osx/Cabal-3.0.1.0 build exe:hledger-ui --ghc-options ""
14812
    Process exited with code: ExitFailure 1

@simonmichael
Copy link
Contributor Author

simonmichael commented Dec 10, 2020 •
edited
Loading 

 hledger-ui  >    <command line>: can't load framework: Cocoa (not found)

This is the first time I've built Haskell software on macos 11, and the problem seems to be https://gitlab.haskell.org/ghc/ghc/-/issues/18446, affecting all current GHC releases. How are other haskell packages in homebrew dealing with this I wonder ? Maybe they don't require system frameworks ?

@simonmichael
Copy link
Contributor Author

It seems like the options for updating (affected?) haskell apps in homebrew right now are:

  • wait for the GHC 8.8.5/8.10.3 release; or
  • try this workaround, involving custom C code which I guess would have to be included in the checksummed tarball.

@carlocab
Copy link
Member

carlocab commented Dec 10, 2020 •
edited
Loading

Does the workaround work for you locally?

One way to use it when installing formulae would be to declare it in a resource block, though you'll want to choose a specific commit hash to refer to in that.

Also, if upstream already have fixes lined up for the next release, it might be better to just use their patches with existing formulae.

Pinging @SMillerDev, who'll know better about whether a workaround is the right thing to do for Homebrew.

@simonmichael
Copy link
Contributor Author

I don't have big sur locally. Thanks for the info, I'll wait to hear from SMiller, but I am inclined to hope that a GHC update will be released and become available in homebrew soon enough.

@SMillerDev
Copy link
Member

Whatever is an official patch from upstream we'd want to use.

@carlocab carlocab mentioned this pull request Dec 19, 2020
Closed
@carlocab
Copy link
Member

the problem seems to be https://gitlab.haskell.org/ghc/ghc/-/issues/18446, affecting all current GHC releases

This seems to be affecting a number of other haskell-based builds too. But I suppose that shouldn't be surprising. See #65759, though I am essentially just repeating @simonmichael's comments there.

@carlocab
Copy link
Member

This should hopefully be unblocked by #67284

@carlocab
Copy link
Member

Picked up your commits, squashed them and included them here: #67284

Hopefully, it fixes some build failures...

@carlocab
Copy link
Member

Actually, you can add whatever fixes to hledger so that it builds on ghc 8.10.3 here too. I'll be able to incorporate them into my ghc PR.

@simonmichael simonmichael reopened this Dec 23, 2020
@simonmichael simonmichael mentioned this pull request Dec 23, 2020
Closed
@simonmichael
Copy link
Contributor Author

Updated to use homebrew's latest ghc; CI is expected to fail for this push, but hopefully will succeed when it's combined with #67284.

@carlocab
Copy link
Member

Thanks. I've added your commit to the ghc PR.

@simonmichael simonmichael force-pushed the master branch 3 times, most recently from 6a961f4 to 08d3255 Compare December 24, 2020 15:56
@simonmichael
Copy link
Contributor Author

Switched back to cabal (temporarily ?) since stack + ghc 8.10.3 isn't working just now.

@carlocab
Copy link
Member

Can you try replacing install_cabal_package to the appropriate calls to system "cabal", etc here?

carlocab
carlocab reviewed Dec 27, 2020
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see it's finally building. Just a few minor suggestions.

Formula/hledger.rb Outdated Show resolved Hide resolved
Formula/hledger.rb Outdated Show resolved Hide resolved
Formula/hledger.rb Outdated Show resolved Hide resolved
Formula/hledger.rb Show resolved Hide resolved
@simonmichael
hledger 1.20.1
e3dabd6 
Update to hledger 1.20.1. Also,
- use hledger-web's built-in tests
- build with a newer stackage snapshot
- build with the latest homebrew ghc, 8.10.3
- add some improvements suggested by reviewers
@simonmichael
add explanatory comment [ci skip]
aebd6be
carlocab
carlocab previously approved these changes Dec 27, 2020
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @simonmichael!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@BrewTestBot
Copy link
Member

⚠️ Bottle publish failed.

@BrewTestBot BrewTestBot dismissed carlocab’s stale review December 27, 2020 20:19

bottle publish failed

@BrewTestBot
Copy link
Member

:shipit: @carlocab has triggered a merge.

@simonmichael
Copy link
Contributor Author

Thank you!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab left review comments

Assignees
No one assigned
Labels
11 Big Sur is specifically affected build failure CI fails while building the software haskell Haskell use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonmichael @carlocab @chenrui333 @SMillerDev @BrewTestBot