Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node@22 node@20 node@18: revision bump to migrate to icu4c@76 #196218

Merged
merged 6 commits into from
Nov 1, 2024
+42 −23
Merged

node@22 node@20 node@18: revision bump to migrate to icu4c@76 #196218

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c778f20
node@22: revision bump to migrate to `icu4c@76`
cho-m Oct 31, 2024
873f407
node@20: revision bump to migrate to `icu4c@76`
cho-m Oct 31, 2024
3c15a97
node@18: revision bump to migrate to `icu4c@76`
cho-m Oct 31, 2024
abe85fb
node@18: update 18.20.4_2 bottle.
BrewTestBot Oct 31, 2024
87767c3
node@20: update 20.18.0_2 bottle.
BrewTestBot Oct 31, 2024
e6a7583
node@22: update 22.10.0_1 bottle.
BrewTestBot Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Formula/n/node@18.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class NodeAT18 < Formula
url "https://nodejs.org/dist/v18.20.4/node-v18.20.4.tar.xz"
sha256 "a76c7ea1b96aeb6963a158806260c8094b6244d64a696529d020547b9a95ca2a"
license "MIT"
revision 1
revision 2

livecheck do
url "https://nodejs.org/dist/"
Expand All @@ -31,7 +31,7 @@ class NodeAT18 < Formula
depends_on "python@3.13" => :build
depends_on "brotli"
depends_on "c-ares"
depends_on "icu4c@75"
depends_on "icu4c@76"
depends_on "libnghttp2"
depends_on "libuv"
depends_on "openssl@3"
Expand All @@ -52,6 +52,12 @@ class NodeAT18 < Formula

fails_with gcc: "5"

# Backport support for ICU 76+
patch do
url "https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9.patch?full_index=1"
sha256 "79a5489617665c5c88651a7dc364b8967bebdea5bdf361b85572d041a4768662"
end

# py3.13 build patch
patch :DATA

Expand Down
10 changes: 8 additions & 2 deletions Formula/n/node@20.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ class NodeAT20 < Formula
url "https://nodejs.org/dist/v20.18.0/node-v20.18.0.tar.xz"
sha256 "7d9433e91fd88d82ba8de86e711ec41907638e227993d22e95126b02f6cd714a"
license "MIT"
revision 1
revision 2

livecheck do
url "https://nodejs.org/dist/"
Expand All @@ -30,7 +30,7 @@ class NodeAT20 < Formula
depends_on "python@3.13" => :build
depends_on "brotli"
depends_on "c-ares"
depends_on "icu4c@75"
depends_on "icu4c@76"
depends_on "libnghttp2"
depends_on "libuv"
depends_on "openssl@3"
Expand All @@ -51,6 +51,12 @@ class NodeAT20 < Formula

fails_with gcc: "5"

# Backport support for ICU 76+
patch do
url "https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9.patch?full_index=1"
sha256 "79a5489617665c5c88651a7dc364b8967bebdea5bdf361b85572d041a4768662"
end

def install
ENV.llvm_clang if OS.mac? && (DevelopmentTools.clang_build_version <= 1100)

Expand Down
9 changes: 8 additions & 1 deletion Formula/n/node@22.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ class NodeAT22 < Formula
url "https://nodejs.org/dist/v22.10.0/node-v22.10.0.tar.xz"
sha256 "3180710d3130ad9df01466abf010e408d41b374be54301d1480d10eca73558e0"
license "MIT"
revision 1

livecheck do
url "https://nodejs.org/dist/"
Expand All @@ -29,7 +30,7 @@ class NodeAT22 < Formula
depends_on "python@3.13" => :build
depends_on "brotli"
depends_on "c-ares"
depends_on "icu4c@75"
depends_on "icu4c@76"
depends_on "libnghttp2"
depends_on "libuv"
depends_on "openssl@3"
Expand All @@ -50,6 +51,12 @@ class NodeAT22 < Formula

fails_with gcc: "5"

# Backport support for ICU 76+
patch do
url "https://github.com/nodejs/node/commit/81517faceac86497b3c8717837f491aa29a5e0f9.patch?full_index=1"
sha256 "79a5489617665c5c88651a7dc364b8967bebdea5bdf361b85572d041a4768662"
end

def install
ENV.llvm_clang if OS.mac? && (DevelopmentTools.clang_build_version <= 1100)

Expand Down
Loading