Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@22 node@20 node@18: revision bump to migrate to icu4c@76 #196218

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Oct 31, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added legacy Relates to a versioned @ formula formula deprecated Formula deprecated long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels Oct 31, 2024
@cho-m cho-m marked this pull request as ready for review October 31, 2024 15:08
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 31, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 18f86f7 Nov 1, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the node-lts-icu76 branch November 1, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula deprecated Formula deprecated icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants