Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tesseract 5.3.0 #116320

Closed
wants to merge 2 commits into from
Closed

tesseract 5.3.0 #116320

wants to merge 2 commits into from

Conversation

equal-l2
Copy link
Contributor

@equal-l2 equal-l2 commented Nov 21, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

tesseract is neural-network-based starting from version 4 and it bundles a bunch of tools useful for training a custom network.
With the change, the tools will also be installed with the main binary.

@BrewTestBot BrewTestBot added the icu4c ICU use is a significant feature of the PR or issue label Nov 21, 2022
@equal-l2
Copy link
Contributor Author

The failure is due to the timeout.
Can someone run the CI with CI-long-timeout please?

@SMillerDev SMillerDev added the long build Set a long timeout for formula testing label Nov 21, 2022
@iMichka iMichka added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 9, 2022
@iMichka
Copy link
Member

iMichka commented Dec 9, 2022

Rebased and running with long build label

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. and removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. labels Dec 9, 2022
@equal-l2
Copy link
Contributor Author

equal-l2 commented Dec 9, 2022

5 formulae failed on test, which is caused by qt:

  CMake Error at qtwebengine/configure.cmake:63 (check_for_ulimit):
    Unknown CMake command "check_for_ulimit".
  Call Stack (most recent call first):
    qtbase/cmake/QtProcessConfigureArgs.cmake:242 (include)

It'll be fixed on qt 5.4.2.
https://bugreports.qt.io/browse/QTBUG-109046

@equal-l2
Copy link
Contributor Author

equal-l2 commented Dec 9, 2022

#115926 seems to include the patch for the qt bug above, so let's wait until that PR is successfully merged.

@chenrui333 chenrui333 added the linux Linux is specifically affected label Dec 10, 2022
@chenrui333
Copy link
Member

need a rerun before the merge, the qt linux stuff would be addressed in that qt PR

@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 14, 2022
@p-linnane
Copy link
Member

Rebased and running with ci-long-timeout.

@cho-m cho-m removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 14, 2022
iMichka
iMichka previously approved these changes Dec 14, 2022
@SMillerDev
Copy link
Member

Linux hit the 6hr limit, this will need a re-run.

@SMillerDev SMillerDev added the CI-linux-self-hosted Build on Linux self-hosted runner label Dec 15, 2022
@p-linnane p-linnane added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-requeued PR has been re-added to the queue labels Dec 15, 2022
@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 16, 2022
SMillerDev
SMillerDev previously approved these changes Dec 16, 2022
@cho-m
Copy link
Member

cho-m commented Dec 16, 2022

Cancelling Linux run as need to clean up old bottles on runner which caused build failure.

chenrui333
chenrui333 previously approved these changes Dec 18, 2022
@chenrui333
Copy link
Member

it has icu4c merge conflict

@equal-l2
Copy link
Contributor Author

Should I do a rebase onto master?

@SMillerDev
Copy link
Member

Let's wait until we get icu4c merged

@chenrui333
Copy link
Member

5.3.0 release is in, while waiting for icu4c, we probably should bump this PR to use it.

@equal-l2 equal-l2 dismissed stale reviews from chenrui333 and SMillerDev via 2eb19f5 December 27, 2022 07:54
@cho-m cho-m changed the title tesseract: install tools for training tesseract 5.3.0 Dec 28, 2022
@p-linnane p-linnane added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 30, 2022
@p-linnane p-linnane removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Dec 31, 2022
@BrewTestBot
Copy link
Member

:shipit: @p-linnane has triggered a merge.

@equal-l2 equal-l2 deleted the tesseract-train branch December 31, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-requeued PR has been re-added to the queue icu4c ICU use is a significant feature of the PR or issue linux Linux is specifically affected long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants