qt 6.4.1

[paperchalice]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

• Enable vulkan support.
• Using licenses listed in LICENSES(except 3rd party libraries)

Currently qt use bundled harfbuzz on macOS, if use brewed harfbuzz, it may report On OS X, AAT is supported only with -qt-harfbuzz., but it is an obsolete warning and is resolved by upstream, should we use brewed version here?

[chenrui333]

qt 6.4.1 test failure across board

[paperchalice]

• Applied the upstream cmake fix
• Fix Vulkan test

[chenrui333]

This commit should be separate out into two.

[chenrui333]

The qt test still failed. We need to test and verify before next run (test run log)

  ==> ./test
  Failed to load vulkan: Cannot load library vulkan: (dlopen(vulkan, 5): image not found)
  initInstance: No Vulkan library available
  Failed to create platform Vulkan instance
  Failed to create Vulkan instance: 0
  Error: qt: failed
  An exception occurred within a child process:
    BuildError: Failed executing: ./test

[paperchalice]

Can't reproduce on my local machine, but got a similar error after brew unlink vulkan-loader 😓.

2022-12-06 16:04:49 +0800

./test

Failed to load vulkan: Cannot load library vulkan: (dlopen(vulkan, 0x0005): tried: 'vulkan' (no such file), '/System/Volumes/Preboot/Cryptexes/OSvulkan' (no such file), '/usr/local/Cellar/qt/6.4.1/lib/QtCore.framework/Versions/A/../../../vulkan' (no such file), '/usr/lib/vulkan' (no such file, not in dyld cache), 'vulkan' (no such file), '/usr/local/lib/vulkan' (no such file), '/usr/lib/vulkan' (no such file, not in dyld cache))
initInstance: No Vulkan library available
Failed to create platform Vulkan instance
Failed to create Vulkan instance: 0

[cho-m]

Could be that your machine is using default dlopen lookup paths, which is more likely on Intel macOS due to standard /usr/local prefix.

Probably should check how Qt is searching for libvulkan. A workaround may be to set a DYLD_*/LD_* environment variable, but that would mean the feature is broken out-of-the-box.

[paperchalice]

I think I can set QT_VULKAN_LIB to override the default path.

[cho-m]

[mvk-error] VK_ERROR_INCOMPATIBLE_DRIVER: Vulkan is not supported on this device. MoltenVK requires Metal, which is not available on this device.

[paperchalice]

Not sure the relation between actions/runner-images#1779 and the failure here...

[paperchalice]

Only check the availability ofQVulkanInstance.

[carlocab]

Currently qt use bundled harfbuzz on macOS, if use brewed harfbuzz, it may report On OS X, AAT is supported only with -qt-harfbuzz., but it is an obsolete warning and is resolved by upstream, should we use brewed version here?

When does the warning appear? Does upstream plan to get rid of it? This is fine for now, but using Homebrew harfbuzz instead of the bundled one should be something we look into for future updates.

[BrewTestBot]

🤖 A scheduled task has triggered a merge.

[paperchalice]

Currently qt use bundled harfbuzz on macOS, if use brewed harfbuzz, it may report On OS X, AAT is supported only with -qt-harfbuzz., but it is an obsolete warning and is resolved by upstream, should we use brewed version here?

When does the warning appear? Does upstream plan to get rid of it? This is fine for now, but using Homebrew harfbuzz instead of the bundled one should be something we look into for future updates.

This warning appears when using -system-harfbuzz on macOS which is not enabled by default but may disappear in qt 6.5.

[carlocab]

Does that mean the warning appears only during the build? If so, we can probably use -system-harfbuzz. If it appears during runtime then we may want to wait until upstream get rid of it.

[paperchalice]

Does that mean the warning appears only during the build? If so, we can probably use -system-harfbuzz. If it appears during runtime then we may want to wait until upstream get rid of it.

Yes, only during the build.

[paperchalice]

Linux bottle is unavailable!

[fxcoudert]

There was already no Linux bottle, since #114917 (comment)

Now the issue is in the test. We get:

==> ./test
  qt.qpa.xcb: could not connect to display 
  qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found.
  This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.
  
  Available platform plugins are: offscreen, minimalegl, linuxfb, eglfs, vnc, wayland-egl, vkkhrdisplay, xcb, wayland, minimal.

If you know how to fix this, a pull request would be welcome.