Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): implement and update icon specs #823

Merged
merged 1 commit into from
Jan 15, 2021
Merged

feat(icons): implement and update icon specs #823

merged 1 commit into from
Jan 15, 2021

Conversation

100stacks
Copy link
Member

@100stacks 100stacks commented Jan 13, 2021 •
edited
Loading

Description

Implement and update icon specs:

Revised Platform Icons

  • account
  • bell
  • billing
  • support
  • ticketing
  • user

New Status Icons

  • critical
  • information (replaces info-circle)
  • ok
  • pending
  • unavailable
  • warning

Deprecated Status Icon

  • info-circle (replace with information

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF-2161

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Jan 13, 2021
@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Jan 13, 2021
@netlify
Copy link

netlify bot commented Jan 13, 2021 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 766c72e

https://deploy-preview-823--helix-ui.netlify.app

@100stacks 100stacks force-pushed the surf-2161-icons-new-specs branch from 00a9961 to 3f4e07d Compare January 14, 2021 20:30
@100stacks
feat(icons): implement and update icon specs
766c72e 
* account
* bell
* billing
* critical
* info-circle (deprecated)
* information
* ok
* pending
* support
* ticketing
* unavailable
* user
* warning
@100stacks 100stacks force-pushed the surf-2161-icons-new-specs branch from 3f4e07d to 766c72e Compare January 14, 2021 20:41
danielmdesigns
danielmdesigns approved these changes Jan 15, 2021
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons and additional documentation look great! These are approved.

lalithkarikelli
lalithkarikelli approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@lalithkarikelli lalithkarikelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@100stacks 100stacks merged commit 6075de7 into master Jan 15, 2021
@100stacks 100stacks mentioned this pull request Jan 15, 2021
Merged
9 tasks
@100stacks 100stacks deleted the surf-2161-icons-new-specs branch March 4, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns approved these changes

@lalithkarikelli lalithkarikelli lalithkarikelli approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@100stacks @danielmdesigns @lalithkarikelli