Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(choice tile): new component specs #814

Merged
merged 3 commits into from
Jan 15, 2021
Merged

feat(choice tile): new component specs #814

merged 3 commits into from
Jan 15, 2021

Conversation

lalithkarikelli
Copy link
Contributor

@lalithkarikelli lalithkarikelli commented Dec 23, 2020 •
edited
Loading

Description

<hx-choicetile>: implementing color palette 2.0 styles

What are the relevant story cards/tickets? Any additional PRs or other references?

Jira: SURF2153

Before you request a review for this PR:

  • For UI changes, did you manually test in recent versions of modern browsers (Chrome, Firefox, and Safari)?
  • For UI changes, did you manually test in IE11 and legacy Edge?
  • Did you add component tests for any new code?
  • Did you run the component unit tests via yarn test to ensure all tests passed?
  • Did you include a screenshot of the component tests?
  • If you changed/added functionality, did you update the demo page and documentation?
  • If needed, did you add or modify the demo test page to test the changed/added functionality?
  • Did you assign reviewers?
  • In Jira, have you linked to this PR on the ticket(s)?

@netlify
Copy link

netlify bot commented Dec 23, 2020 •
edited
Loading

Deploy preview for helix-ui ready!

Built with commit 5daabc3

https://deploy-preview-814--helix-ui.netlify.app

@lalithkarikelli lalithkarikelli marked this pull request as ready for review December 23, 2020 14:52
@100stacks 100stacks added this to the HelixUI-v2.0.0 milestone Dec 23, 2020
@100stacks 100stacks added the 🆕 New Component Specs Updated Component Specifications label Dec 23, 2020
@100stacks 100stacks requested review from 100stacks, badejayayesubabu and danielmdesigns and removed request for badejayayesubabu January 11, 2021 18:50
badejayayesubabu
badejayayesubabu approved these changes Jan 12, 2021
View reviewed changes
Copy link
Collaborator

@badejayayesubabu badejayayesubabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEV LGTM

danielmdesigns
danielmdesigns suggested changes Jan 12, 2021
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the design spec was not correct for Option Tiles. I have updated Abstract Style Guide specs.

  1. Tile icons should match that of the state (hover, pressed)
  2. I also included a disabled state

My apologies for overlooking these. Please update these two and let me know when I can take another look. That should solve any issues I have.

@100stacks 100stacks added the PR: Comments Provided PR: Comments Provided label Jan 12, 2021
@lalithkarikelli
Copy link
Contributor Author

I realized the design spec was not correct for Option Tiles. I have updated Abstract Style Guide specs.

  1. Tile icons should match that of the state (hover, pressed)
  2. I also included a disabled state

My apologies for overlooking these. Please update these two and let me know when I can take another look. That should solve any issues I have.

@danielmdesigns i have pushed the changes , please review at https://deploy-preview-814--helix-ui.netlify.app/components/choice-tile . Thanks !

100stacks
100stacks requested changes Jan 13, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lalithkarikelli, it looks like we have legacy box shadow focus styles on Choice Tile:

Screen Shot 2021-01-13 at 10 16 29 AM

Screen Shot 2021-01-13 at 10 16 40 AM

Please see https://deploy-preview-814--helix-ui.netlify.app/components/choice-tile/test.html

100stacks
100stacks requested changes Jan 14, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the focus state box-shadow.

src/scss/components/choice-tile/mixins/_hxChoiceTile.scss Outdated
@@ -8,8 +8,20 @@
box-shadow: $focus-glow;
Copy link
Member

@100stacks 100stacks Jan 14, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to:

box-shadow: 0 0 4px rgba($purple-700, 0.5);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes have been done, please review.

@100stacks 100stacks removed the PR: Comments Provided PR: Comments Provided label Jan 15, 2021
100stacks
100stacks approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev LGTM

@100stacks 100stacks changed the title refactor(hx-choicetile): update component specs feat(choice tile): new component specs Jan 15, 2021
100stacks
100stacks reviewed Jan 15, 2021
View reviewed changes
docs/components/icon/index.html
@@ -64,7 +64,7 @@ <h2 id="status-icons">Status Icons</h2>

<div class="example">
<div>
<hx-icon type="info-circle" style="color: #296CDC" class="size-2x"></hx-icon>
<hx-icon type="information" style="color: #296CDC" class="size-2x"></hx-icon>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR #823 - update the demo to use the new icon type.

100stacks
100stacks reviewed Jan 15, 2021
View reviewed changes
docs/components/icon/index.html
@@ -74,7 +74,7 @@ <h2 id="status-icons">Status Icons</h2>

<footer>
{% code 'html' %}
<hx-icon type="info-circle" style="color: #296CDC"></hx-icon>
<hx-icon type="information" style="color: #296CDC"></hx-icon>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PR #823 - update the demo to use the new icon type.

danielmdesigns
danielmdesigns suggested changes Jan 15, 2021
View reviewed changes
Copy link

@danielmdesigns danielmdesigns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the invalid color to match status color #D6251F

100stacks
100stacks reviewed Jan 15, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the invalid color to match status color #D6251F

@danielmdesigns, invalid status color updated. Please see screenshot below:

Screen Shot 2021-01-15 at 2 50 28 PM

100stacks
100stacks approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@100stacks 100stacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielmdesigns, I'm going to go ahead and merge this PR #814 so that we can include it in today's release.

We can make any other changes in a fast follow. Thanks.

@100stacks 100stacks merged commit 0c98cd2 into HelixDesignSystem:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmdesigns danielmdesigns danielmdesigns requested changes

@100stacks 100stacks 100stacks approved these changes

@badejayayesubabu badejayayesubabu badejayayesubabu approved these changes

Assignees
No one assigned
Labels
🆕 New Component Specs Updated Component Specifications
Projects
None yet
Milestone
HelixUI-v2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lalithkarikelli @danielmdesigns @100stacks @badejayayesubabu