Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new quest: post_office type #737

Merged
merged 4 commits into from
Feb 9, 2025
Merged

Conversation

mcliquid
Copy link

@mcliquid mcliquid commented Feb 7, 2025

Fixes #736

The quest works and I have already tested it in practice in my fork.
Just to clarify:

  1. Does the icon fit? (Quick and dirty combo of two existing icons: shop and mail)
  2. Would the strings need to be further optimized?
  3. Do you need an option “Is not a post office”?

@Helium314
Copy link
Owner

Does the icon fit? (Quick and dirty combo of two existing icons: shop and mail)

I think it's fine though maybe it would fit better with the red and white thing removed?

Do you need an option “Is not a post office”?

No, tag editor or leaving a note is fine. And I think there is the "does not exist" answer too.

Would the strings need to be further optimized?

I think there is no need for quest_postOffice_disabled_msg (you could use the default SCEE message), but if you want to keep it that's fine too.
Any quest_postOffice_postOffice should be renamed to quest_postOffice_postPartner.
Otherwise I don't know... strings seem ok to me.

Could you rename the quest to something like AddPostOfficeType?

@mcliquid
Copy link
Author

mcliquid commented Feb 8, 2025

I think it's fine though maybe it would fit better with the red and white thing removed?

The first is the previous one, the second is the roof moved up to create more space, the third is completely without a roof - I call it the microwave 🤣
image

Could you rename the quest to something like AddPostOfficeType?

Should I also rename the folder from “post_office” to “post_office_type”?
Like existing parking_type, lamp_type, memorial_type, police_type, ...?

@Helium314
Copy link
Owner

Should I also rename the folder from “post_office” to “post_office_type”?

Leaving it as post_office is fine.

I call it the microwave 🤣

Oh I see. This is a weird sort of ugly. Then choose whatever you like. I slightly prefer the middle version.

@mcliquid
Copy link
Author

mcliquid commented Feb 8, 2025

Oh I see. This is a weird sort of ugly. Then choose whatever you like. I slightly prefer the middle version.

Here you are 🙂

@Helium314 Helium314 merged commit 282855d into Helium314:modified Feb 9, 2025
@mcliquid mcliquid deleted the post_office branch February 9, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Quest: What type is this post office? (post_office)
2 participants