Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump node.js runtime version #437

Merged
merged 8 commits into from
Aug 29, 2023
Merged

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Aug 28, 2023

Acceptance Criteria

  • CodeBuild should use Node.js 16 as runtime to build and deploy the project
  • We should use npm ci in the build, instead of npm install

TODO

  • Make sure CodeBuild uses a newer Docker image that supports Node.js 16

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged
  • Make sure either the unit tests and/or the QA tests are capable of testing the new features
  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@luislhl luislhl self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #437 (d1ad798) into master (d662883) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          40       40           
  Lines        2458     2458           
  Branches      278      278           
=======================================
  Hits         2350     2350           
  Misses        108      108           

@luislhl luislhl merged commit b3820ec into master Aug 29, 2023
5 checks passed
@luislhl luislhl deleted the ci/bump-nodejs-runtime-version branch August 29, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants