Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feature-activation): add signal bits field #428

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jun 20, 2023

Acceptance Criteria

  • Add signal_bits field to Transaction

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@glevco glevco self-assigned this Jun 20, 2023
@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from b940b30 to 2e8c1e5 Compare June 20, 2023 19:35
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #428 (0cb568f) into master (a3a71a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #428   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          40       40           
  Lines        2458     2458           
  Branches      278      278           
=======================================
  Hits         2350     2350           
  Misses        108      108           
Impacted Files Coverage Δ
events/nftCreationTx.ts 100.00% <ø> (ø)
src/types.ts 98.65% <ø> (ø)

@glevco glevco force-pushed the feat/feature-activation/signal-bits branch from 2e8c1e5 to 0cb568f Compare June 20, 2023 21:04
@glevco glevco marked this pull request as ready for review June 20, 2023 21:05
@glevco glevco requested a review from r4mmer June 20, 2023 21:06
@glevco glevco merged commit 6463b8e into master Jun 23, 2023
@glevco glevco deleted the feat/feature-activation/signal-bits branch June 23, 2023 16:45
@andreabadesso andreabadesso mentioned this pull request Aug 25, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants