Fix: Missing TextIDs for MQ PAL and change lava size

[Archez]

MQ PAL had bad offsets for the messages making it not have the first 4 messages which are Adult trade GI messages and would crash. This address the offsets and adds some debug asserts to help catch when the first text ID is not found.

This also adds a little cleanup and tweaks to the recent KD lava changes. The main change is that one of the lava textures seemingly is "too large" from decomp. It has a size of 64x64 where as all other lava textures are 32x64. The original game code that operates on this lava texture only ever reads the first 2048 pixel values (which is 32x64). Looking at the png output of the 64x64 reveals that the data should have been more like 32x128, and the first half of the data matches the second half.

For texture pack makers, this texture really should just be 32x64 so they can make the "correct" looking texture image before packing.

The relevant part that shows only the first 2048 pixel values are read from the lava texture, where temp_s1 is sLavaFloorLavaTex

Shipwright/soh/src/overlays/actors/ovl_Boss_Dodongo/z_boss_dodongo.c

Lines 219 to 224 in 3cf9d65

	for (i = 0; i < 2048; i += 32) {
	temp = sinf((((i / 32) + (s16)((arg2 * 50.0f) / 100.0f)) & 0x1F) * (M_PI / 16)) * arg3;
	for (i2 = 0; i2 < 32; i2++) {
	sp54[i + ((temp + i2) & 0x1F)] = temp_s1[i + i2];
	}
	}

There is also an offset fix for the lava textures on NMQ PAL where it was off by a few pixels.

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip