Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

King Dodongo lava textures need updates #13

Closed
Archez opened this issue Nov 23, 2023 · 3 comments
Closed

King Dodongo lava textures need updates #13

Archez opened this issue Nov 23, 2023 · 3 comments

Comments

@Archez
Copy link

Archez commented Nov 23, 2023

On the SoH side I am repairing the lava effects for King Dodongo's room via HarbourMasters/Shipwright#3434

With 8.0.0 we fixed an issue where one of the lava textures had the width and height values reversed. This means you will need to remake that texture to match the correct height/width ratio.

To make the lava effects work, in the code it requires that some pixel data is copied from one texture over another in-game. This means that all the lava textures need to have a similar scale.

The textures of concern and their original sizes are the following:
scenes/shared/ddan_boss_scene/gDodongosCavernBossLaveFloorTex - width: 32, height: 64
ovlerlays/ovl_Boss_Dodongo/sLavaFloorLavaTex - width: 64, height 64 Edit: now width: 32, height 64 after HarbourMasters/Shipwright#3449
ovlerlays/ovl_Boss_Dodongo/sLavaFloorRockTex - width: 32, height 64

So for example if you scale one of these by 8x, then all of them need to be scaled the same.

In the linked PR I used your textures (after fixing the scaling on my end) as reference.

@GhostlyDark
Copy link
Owner

Why is sLavaFloorLavaTex 64x64? All emulator dumps for these are 32x64, so it doesn't seem correct to me.
I did take care of the texture resolutions via 7169963. Let me know if there's anything else I should adjust.

@Archez
Copy link
Author

Archez commented Nov 26, 2023

Why is sLavaFloorLavaTex 64x64? All emulator dumps for these are 32x64, so it doesn't seem correct to me.

I dug into it, and it seems the size was set by decomp, but the game code only reads 32x64 pixels worth of data from this texture. It's safe to say this is probably just an error in the texture size that can be corrected.

I have done that here HarbourMasters/Shipwright#3449, once that is in you can get an updated manifest.json that has the corrected height/width values.

So now sLavaFloorLavaTex is basically a copy of gDodongosCavernBossLaveFloorTex

@GhostlyDark
Copy link
Owner

7ac2996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants