Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #44 returned #76

Closed
ABM-Dan opened this issue Dec 9, 2016 · 15 comments
Closed

Issue #44 returned #76

ABM-Dan opened this issue Dec 9, 2016 · 15 comments

Comments

@ABM-Dan
Copy link

ABM-Dan commented Dec 9, 2016

Opening this because I don't know how to reopen #44, all the relevant info is there.

@dbiagi
Copy link

dbiagi commented Dec 9, 2016

Just discovered this issue. After reformat code, my app was broken.

@JKetelaar
Copy link

Same here

@avramcosmin
Copy link

Same here with use Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity and a bunch of many other imports after installing PhpStorm 2016.3.1.

@dorcyv
Copy link

dorcyv commented Dec 11, 2016

I think this issue is related

@Haehnchen
Copy link
Owner

fine a self resolving issue for me :)

@Haehnchen Haehnchen added the api label Dec 11, 2016
@acelaya
Copy link

acelaya commented Dec 12, 2016

Same here. It happens with any kind of annotation.
As a temporary workaround, I have noticed that aliased annotations are not marked as unused.

In this case, the Inject annotation is marked as unsued:

<?php
namespace App;

use Acelaya\ZsmAnnotatedServices\Annotation\Inject; // <- Unused

class Foo
{
    /**
     * @Inject({Cache::class})
     */
    public function __construct(Cache $cache)
    {
        $this->cache = $cache;
    }
}

But not in this case:

<?php
namespace App;

use Acelaya\ZsmAnnotatedServices\Annotation as DI;

class Foo
{
    /**
     * @DI\Inject({Cache::class})
     */
    public function __construct(Cache $cache)
    {
        $this->cache = $cache;
    }
}

@luispabon
Copy link

Can confirm this is also happening to me, on 2016.3.1 and latest plugin.

@rvanlaak
Copy link

@Haehnchen you probably mean that it isn't due to the plugin, but to the PHPStorm API right? #76 (comment)

@linaori
Copy link

linaori commented Dec 14, 2016

Same here, tried with any non-aliased annotation, but everything is detected as unused. This goes for SensioLabs Route, Template, Security; Symfony Route; Custom Annotations. I think it's really broken :(

@dorcyv
Copy link

dorcyv commented Dec 14, 2016

I can confirm that this issue is solved by this build:
CLion 2016.3.1
Build #CL-163.9166.31, built on December 13, 2016
JRE: 1.8.0_112-release-408-b2 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

@linaori
Copy link

linaori commented Dec 14, 2016

I'm locally (EAP) running: Build version: PhpStorm 2016.3.2 EAP Build #PS-163.10154.2 December 13, 2016 and I can confirm this is fixed.

@ABM-Dan
Copy link
Author

ABM-Dan commented Dec 14, 2016

Thank you @iltar 😄

@vudaltsov
Copy link

For those (like me 10 minutes ago) who don't know where to find EAP builds of PhpStorm.

@lifo101
Copy link

lifo101 commented Jan 3, 2017

I commented on #44 by mistake. I just upgraded IntelliJ to 2016.3.2 and this bug started to occur. If I use my other computer that still has 2016.3 this is not an issue. Both computers are using PHP-Annotation plugin v4.2.

Bugged:

IntelliJ IDEA 2016.3.2
Build #IU-163.10154.41, built on December 21, 2016
Licensed to ...
You have perpetual fallback license for this version
Subscription is active until November 29, 2017
JRE: 1.8.0_112-release-408-b6 x86
JVM: OpenJDK Server VM by JetBrains s.r.o

Works:

IntelliJ IDEA 2016.3
Build #IU-163.7743.44, built on November 17, 2016
Licensed to ...
You have perpetual fallback license for this version
Subscription is active until November 29, 2017
JRE: 1.8.0_25-b18 amd64
JVM: Java HotSpot(TM) 64-Bit Server VM by Oracle Corporation

@Haehnchen
Copy link
Owner

fyi: 2016.3.2 is working as expected 2016.3.1 is now blacklisted: https://github.com/Haehnchen/idea-php-annotation-plugin/blob/master/.travis.yml#L22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests