PhpStorm 10: Unused symfony2 annotations imports

[scaytrase]

Annotation imports became mark unused right after aftercompletion succeedes.

PhpStorm 10.0
Build #PS-143.381, built on October 31, 2015
JRE: 1.8.0_51-b16 x86
JVM: Java HotSpot(TM) Server VM by Oracle Corporation

Plugin version: 2.6.1

[scaytrase]

PhpStorm 9.0.2 with the same plugin version render imports OK

PhpStorm 9.0.2
Build #PS-141.2462, built on August 18, 2015
JRE: 1.8.0_51-b16 x86
JVM: Java HotSpot(TM) Server VM by Oracle Corporation

[lsv]

Can confirm, just changed to PhpStorm 10 now.

If you remove the import line, then the annotation actually says it cant find the class

[Haehnchen]

I did a clean installation, its working fine.

@lsv that correct class is not imported so not known ;)
@scaytrase try a cache invalidation and rebuild it for new PhpStorm10 environment: File > Invalidate Cache

[scaytrase]

Invalidate Cache and Restart, than reindexing did nothing. Any other ideas?

Reinstall plugin and reindex didn't help

[scaytrase]

Hell, I've even dropped .WebIde100 folder and reconfigured plugins. Same story. I've left only two custom plugins enabled - Symfony2 and PHP Annotations, rebuilt cache and restarted. Nothing changed.

[lsv]

@Haehnchen ofcourse, it was just to show that the @route actually looked for a class.

In symfony fullstack there are two different classes that gives you the route annotation.

Symfony\Component\Routing\Annotation\Route and Sensio\Bundle\FrameworkExtraBundle\Configuration\Route if you choose the frameworkextra route annotation then it says the class is never used.

But if you use the component annotation then it works as before.

But it is not just the route annotation, the Method annotation which only is in the frameworkextra does not work at all.

(By "work" I mean it shows up as "class import never used", just in the first screenshot from OP)

[scaytrase]

Yeah @lsv , Interesting note - component annotation marked as used correctly. At the same time FrameworkBundle one - not

[lsv]

The only difference I can see on the two classes are

The component route has the Target annotation, and the framework does not.

But again, both worked perfect in PHPStorm 9 (and still does) but not in 10 (so what have changed I dont know)

[linaori]

It seems like the following annotations are not detected when used:

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

The following work fine:

use Doctrine\ORM\Mapping as ORM;
use Symfony\Component\Routing\Annotation\Route;

This is quite an issue for me as it would mean I remove used use statements.

[lsv]

+1

[hoshsadiq]

Any update on this?

[Haehnchen]

yes. targets are missing in all classes https://github.com/sensiolabs/SensioFrameworkExtraBundle/tree/master/Configuration. but that should not break, will check that changes between PhpStorm 9 > 10 psi-struct/lexer

[desarrolla2]

+1

[Haehnchen]

can someone provide some project background. symfony version, ... ?. that ever i am trying all works as expected. :)

• try drop cache folder?
• multiple class names for eg Route?

[scaytrase]

@Haehnchen currently I cannot reproduce this issue neither with PS10.0.3 nor with PS11 EAP (plugins are latest). Maybe something go fixed silently last two months.

If some other confirm - then, issue should be gone.

[linaori]

I think it has indeed been fixed in a patch in-between. I can verify tomorrow but I cannot remember running into this issue the past weeks.

[linaori]

Update, I'm running 10.0.3 (jan 8) with annotations 2.6.2, and it's working here.

[fracasula]

Same here with Ubuntu and PHPStorm 10.0.3. With me what's not working are other classes though so I don't think it's this plugin the culprit. PHPStorm says the ParamFetcher class that I'm using with type hinting is never used, plus a trait I wrote myself.

[hoshsadiq]

@fracasula I think your issue is different. This plugin is to do with annotations, yours is a PhpStorm built in feature. You should raise this as an issue on YouTrack on Intellij's website.

[fracasula]

@hoshsadiq That's why I wrote "so I don't think it's this plugin the culprit" in my previous comment. I was trying to point out that maybe this whole thing could probably be just about PHPStorm and not the plugin at all. Just saying though, so if you guys are sure about this then it makes sense you keep posting here.

[hackzilla]

For future reference, this has been fixed by installing the PHP Annotations plugin.

https://youtrack.jetbrains.com/issue/WI-30512

[Haehnchen]

so closed

[plfort]

I still have this issue with PHP Annotation 3.0.1 and PHPStorm 2016.1.2 (145.1616).
Cleaning index or reinstalling the plugin did not help.
Am i missing something ?

[denisvmedia]

@Haehnchen
I have this problem too, but in PhpStorm 10.0.4 and the plugin version 2.6.2. Tried clearing cache - no results. Tried re-installing it - no results. Shoudn't we re-open this issue?

[Haehnchen]

not supporting version < 2016.x because of different api levels. versions +2016.1 need also some updates because of #55

[vpArth]

PhpStorm 2016.3.1
Build #PS-163.9735.1, built on December 6, 2016

Same issue:

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;

Both are never used

[vpArth]

Workaround is aliasing:

use Sensio\Bundle\FrameworkExtraBundle\Configuration as C;

/**
 * @C\Route(...)
 * @C\Method()
 */

[shyinyong]

You can install PHP Annotations plugin!

[lashae]

It is already installed on the latest build of Phpstorm.

[linaori]

It's fixed again in the latest EAP of phpstorm

[weph]

Will this fix also be released for 2016.3.1?

[dramentol]

I have the same problem.

PhpStorm 2016.3.1
Build #PS-163.9735.1, built on December 6, 2016

PHP Annotations 4.2

Edit:
as @iltar pointed, it's fixed in the latest EAP

[igops]

The last build of PhpStorm has a fix for the issue!

PhpStorm 2016.3.2
Build #PS-163.10504.2, built on December 20, 2016

PHP Annotations 4.2

Voilà:

[lifo101]

I just upgraded to 2016.3.2 and now these annotations are broken. I've tried invalidating/restarting/re-indexing/reinstalling the PHP annotations plugins, etc. And nothing seems to work. :(

IntelliJ IDEA 2016.3.2
Build #IU-163.10154.41, built on December 21, 2016
Licensed to ...
You have perpetual fallback license for this version
Subscription is active until November 29, 2017
JRE: 1.8.0_112-release-408-b6 x86
JVM: OpenJDK Server VM by JetBrains s.r.o

[igops]

@lifo101 which version of PHP Annotations?

[lifo101]

v4.2.

…

-- Jason

On Tue, Jan 3, 2017 at 9:28 AM, Igor Kugaudo ***@***.***> wrote: @lifo101 <https://github.com/lifo101> which version of PHP Annotations? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#44 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWa6RurKDjK69LLTvKFuMmmFpk7nO8tks5rOlsqgaJpZM4GaT_i> .

[dfreudenberger]

same here, running php annotations v4.2 with intellij 2016.3.2

[mrfreitas]

I can confirm that Intellij 2016.3.2 with php annotations v4.2 it's having this problem

[lifo101]

Simple workaround (the aliasing suggestion someone made didn't work for me) is to simply reference the class of the unused imports. This way when you optimize imports Ctrl-Alt-L it won't remove those imports)

    protected function dummy()
    {
        // dummy code to fix bug in 'use' statements not being seen 
        // (IntelliJ v2016.3.2 + PHP Annotations v4.2)
        Route::class;
        Security::class;
    }

[dewos]

@lifo101 you can use @see in annotation, it is more clean

/**
* @Route("/request")
*
* @see Route
*/
class FooController

[PhilETaylor]

This is happening again :-(

PHP Annotation Plugin 5.2.1
PhpStorm 2018.1 EAP
Build #PS-181.3741.23, built on February 14, 2018
JRE: 1.8.0_152-release-1136-b11 x86_64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o
macOS 10.13.4

EDIT:
Disregard, I see a new build is now available 20 hours ago #108

[sawmurai]

Happens in 2018.1

[scaytrase]

in 2018.1 it happens because of old version plugin incompatibility. you should re-install (remove, restart, install, restart) plugins in order get them back to life

[ddelrio1986]

Recently upgraded PHPStorm and had to do exactly as @scaytrase described above to get warnings about "use Doctrine\ORM\Mapping as ORM;" imports not being used even though I was using it within docblock annotations. I just uninstalled the PHP Annotations plugin, restarted PHPStorm, installed the PHP Annotations plugin, then restarted PHPStorm again.