Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove strdup implementation #447

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Remove strdup implementation #447

merged 1 commit into from
Sep 25, 2023

Conversation

derobins
Copy link
Member

Every platform we support has strdup, so this can be removed.

@derobins
Remove strdup implementation
a1315c4 
Every platform we support has strdup, so this can be removed.
@derobins derobins added Component - C Library Core C library issues Type - Improvement Improvements that don't add a new feature or functionality Priority - 1. High 🔼 These are important issues that should be resolved in the next release labels Sep 23, 2023
@derobins
Copy link
Member Author

The priority is "high" because this creates warnings about duplicated symbols.

@schwehr
Copy link
Collaborator

schwehr commented Sep 24, 2023

Thanks! This will fix #446

schwehr
schwehr approved these changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@schwehr schwehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this change and it fixed the issue was running into.

@schwehr
Copy link
Collaborator

schwehr commented Sep 24, 2023

Not for this PR, but can HIstrncpy also be replaced with systems' strncpy

@derobins
Copy link
Member Author

Not for this PR, but can HIstrncpy also be replaced with systems' strncpy

Yes, but since there that function drops \0 in the last byte, there's a little extra work to spread that around the library. I figured I'd do that when I got back from vacation since that might open some cans of worms when it comes to inappropriate string handling.

@derobins derobins merged commit 9a53936 into HDFGroup:master Sep 25, 2023
44 checks passed
@derobins derobins deleted the yank_extra_strdup branch March 3, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schwehr schwehr schwehr approved these changes

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derobins @schwehr