Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate strdup symbol #446

Closed
schwehr opened this issue Sep 15, 2023 · 3 comments
Closed

Duplicate strdup symbol #446

schwehr opened this issue Sep 15, 2023 · 3 comments
Assignees
Labels
Component - C Library Core C library issues Confirmed Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub

Comments

@schwehr
Copy link
Collaborator

schwehr commented Sep 15, 2023

I'm hitting an error with some sanitizer builds with the 2nd strdup in hdf4 caused by #442 that did HDstrdupstrdup in hdfalloc.c

strdup(const char *s)

backward reference detected: strdup in third_party/gdal/_objs/port_lib/json_object.pic.o refers to third_party/hdf4/_objs/libdf/hdfalloc.pic.o
@derobins
Copy link
Member

I'll remove that duplicate symbol. I didn't even know that existed. I'll probably also replace HIstrncpy (in a separate PR) while I'm at it.

@bmribler bmribler added Component - C Library Core C library issues Confirmed Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub labels Sep 18, 2023
@bmribler bmribler assigned bmribler and unassigned derobins Sep 18, 2023
@schwehr
Copy link
Collaborator Author

schwehr commented Sep 19, 2023

Also here:

HDFPUBLIC char *strdup(const char *s);

@derobins
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - C Library Core C library issues Confirmed Type - Bug Please report security issues to help@hdfgroup.org instead of creating an issue on GitHub
Projects
None yet
Development

No branches or pull requests

3 participants