-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avon (MS1) #13
Merged
Merged
Avon (MS1) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Gum-Joe
reviewed
Jan 2, 2021
Add KECHG integration and close #2. Add a new TabContainer view to contain the different versions of the site for KECHB and KECHG. Code cleanup.
Move events to separate file Add basics of houser and fundraisers Move around banners Add House banner.
Add descriptions
Only show desc. if there Onyl show tickets on sale if event tickets not yet on sale
Now the offical Avon branch |
…ka into Add-Proper-Mobile-Layout
…ka into Add-Proper-Mobile-Layout # Conflicts: # frontend/src/App.css fixed by accepting Gum-Joe's
…ka into Add-Proper-Mobile-Layout
…ka into Add-Proper-Mobile-Layout
Give KECHG their own data Add a header for if there are no events Move event fetch logic to a function given to SIteContainer
Change maximising CSS (so stuff fills the page) to min-heights so stuff is layed out vertically correctly.
Add basic layout with buttons, etc Add flex boxes
Fix issue wth height:100vh Fix the events page
Position social icons
Add Footer and Social Icons
NOT READY TO MERGE YET |
Gum-Joe
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
largely completes #3