Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KECHG integration #16

Merged
merged 16 commits into from
Jan 12, 2021
Merged

Add KECHG integration #16

merged 16 commits into from
Jan 12, 2021

Conversation

Gum-Joe
Copy link
Owner

@Gum-Joe Gum-Joe commented Jan 5, 2021

Add KECHG integration so they can see what week it is and have an events list - see #2.
This also means generalising components so they can be used regardless of the school entered as a prop.

Once done, closes #2.

Fix an issue where a's weren't displaying in blue
Add ability to set the day when the Week A/B marker event is
@Gum-Joe Gum-Joe added the enhancement New feature or request label Jan 5, 2021
@Gum-Joe Gum-Joe linked an issue Jan 5, 2021 that may be closed by this pull request
7 tasks
@Gum-Joe Gum-Joe requested a review from ILikeTeaALot January 5, 2021 20:55
@Gum-Joe Gum-Joe marked this pull request as ready for review January 10, 2021 19:14
@Gum-Joe Gum-Joe marked this pull request as draft January 10, 2021 19:15
Still checking if works....
Add GTAG types
@Gum-Joe Gum-Joe marked this pull request as ready for review January 10, 2021 20:53
Copy link
Collaborator

@ILikeTeaALot ILikeTeaALot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all looks good! (the tab stuff is all mine so not much to review there haha)

@Gum-Joe Gum-Joe merged commit 255ada6 into PR-Add-Events-Section Jan 12, 2021
@Gum-Joe Gum-Joe added this to the Avon (MS1) milestone Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KECHG integration
2 participants