Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/lfs removal #1

Merged
merged 6 commits into from
Jun 2, 2024
Merged

Feature/lfs removal #1

merged 6 commits into from
Jun 2, 2024

Conversation

JaXt0r
Copy link

@JaXt0r JaXt0r commented Jun 2, 2024

To test

  1. Start Unity once
  2. Load game to boot world.scene (FeatureFlag.SkipMainMenu is fine)
  3. Please test also with an Android build. I checked the .meta files of the .dll's/.so's about when they should be baked into an MVR release, but please double check if it works correctly.

Changes:

  • Moved .dll dependencies (ZenKit etc.) into package (Already set, Unity will download once Editor is opened)
  • Moved world scenes into same package (Already linked inside Build Settings; therefore world.zen will load)
  • Removed DLLs for FilePickerButton

@JaXt0r JaXt0r requested a review from Tyroonis June 2, 2024 06:11
@Tyroonis
Copy link

Tyroonis commented Jun 2, 2024

They are still causing problems.
But we can also do this as an extra repo.
The Pico OpenXR package is unfortunately not available from Pico on github
image

https://developer.picoxr.com/resources/
We need PICO Unity OpenXR SDK.

Copy link

@Tyroonis Tyroonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build looks good.
I'm still creating a followIssue for the PicoFix

@JaXt0r JaXt0r merged commit 97017bd into main Jun 2, 2024
@JaXt0r JaXt0r deleted the feature/lfs-removal branch June 2, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants