Use milestone title instead of id for githubmilestone #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the milestone id that was used before is the intertal github id for the row, not the sequencial milestone number included in the url. As such I didn't keep it at all as I assumed that it was fairly useless for everyone. The milestone number may eventually be useful but I guess we should wait until someone asks for it explicitely before adding it to avoid some sort of "UDA creap". Fix issue GothenburgBitFactory#365
|
Nice catch. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the milestone id that was used before is the intertal github
id for the row, not the sequencial milestone number included in the url.
As such I didn't keep it at all as I assumed that it was fairly useless
for everyone.
The milestone number may eventually be useful but I guess we should
wait until someone asks for it explicitely before adding it to avoid
some sort of "UDA creap".
Fix issue #365