Merge pull request #372 from gdetrez/github-milestone

Use milestone title instead of id for githubmilestone
GothenburgBitFactory · Aug 29, 2016 · e331ec8 · e331ec8
2 parents b6f3620 + 321f79f
commit e331ec8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/bugwarrior/services/github.py b/bugwarrior/services/github.py
@@ -127,7 +127,7 @@ class GithubIssue(Issue):
             'label': 'Github Updated',
         },
         MILESTONE: {
-            'type': 'numeric',
+            'type': 'string',
             'label': 'Github Milestone',
         },
         REPO: {
@@ -155,7 +155,7 @@ def _normalize_label_to_tag(self, label):
     def to_taskwarrior(self):
         milestone = self.record['milestone']
         if milestone:
-            milestone = milestone['id']
+            milestone = milestone['title']
 
         body = self.record['body']
         if body:

diff --git a/tests/test_github.py b/tests/test_github.py
@@ -26,7 +26,7 @@ class TestGithubIssue(AbstractServiceTest, ServiceTest):
         'url': 'https://api.github.com/repos/arbitrary_username/arbitrary_repo/issues/1',
         'number': 10,
         'body': 'Something',
-        'milestone': {'id': 'alpha'},
+        'milestone': {'title': 'alpha'},
         'labels': [{'name': 'bugfix'}],
         'created_at': arbitrary_created.isoformat(),
         'updated_at': arbitrary_updated.isoformat(),
@@ -69,7 +69,7 @@ def test_to_taskwarrior(self):
             issue.UPDATED_AT: self.arbitrary_updated,
             issue.CREATED_AT: self.arbitrary_created,
             issue.BODY: self.arbitrary_issue['body'],
-            issue.MILESTONE: self.arbitrary_issue['milestone']['id'],
+            issue.MILESTONE: self.arbitrary_issue['milestone']['title'],
         }
         actual_output = issue.to_taskwarrior()