Support specific buildpacks for buildpack artifact

[kissmikijr]

Relates to #3581

Description
Buildpack artifact now able to pass the buildpacks parameter to the pack.Build command. So now we can specify which builder and in which order should buildpacks use.

User facing changes

n/a

Before
n/a

After
n/a
Next PRs.
n/a
-->

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Mentions any output changes.
• Adds documentation as needed: user docs, YAML reference, CLI reference.
• Adds integration tests if needed.

Reviewer Notes

• The code flow looks good.
• Unit test added.
• User facing changes look good.

Release Notes

Examples of user facing changes:
- Skaffold config changes like
  e.g. "Add buildArgs to `Kustomize` deployer skaffold config."
- Bug fixes
  e.g. "Improve skaffold init behavior when tags are used in manifests"
- Any changes in skaffold behavior
  e.g. "Artifact caching is turned on by default."

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[kissmikijr]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[kissmikijr]

I've never written any go code, and I didn't see test file for lifecycle.go, so I did not write unittests for this change. If it is needed any help would be appreciated :)

[codecov]

Codecov Report

Merging #3584 into master will decrease coverage by 0.07%.
The diff coverage is 78.94%.

Impacted Files	Coverage Δ
pkg/skaffold/schema/latest/config.go	100% <ø> (ø)	⬆️
pkg/skaffold/build/local/local.go	60% <0%> (ø)	⬆️
pkg/skaffold/docker/image_util.go	0% <0%> (ø)	⬆️
pkg/skaffold/schema/v2alpha2/upgrade.go	85.71% <100%> (ø)	⬆️
pkg/skaffold/build/cache/lookup.go	100% <100%> (ø)	⬆️
pkg/skaffold/build/buildpacks/lifecycle.go	81.08% <100%> (+9.65%)	⬆️
pkg/skaffold/build/buildpacks/metadata.go	100% <100%> (ø)
pkg/skaffold/initializer/init.go	62.74% <100%> (ø)	⬆️
pkg/skaffold/build/cache/cache.go	56.81% <100%> (+1%)	⬆️
cmd/skaffold/app/cmd/init.go	100% <100%> (ø)	⬆️
... and 15 more

[kissmikijr]

@googlebot I fixed it.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[dgageot]

@kissmikijr Could you add a test case here: https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/build/buildpacks/build_test.go#L53?

[kissmikijr]

Yes! Thank you for the help :)

…

On Sun, 26 Jan 2020, 15:47 David Gageot, ***@***.***> wrote: @kissmikijr <https://github.com/kissmikijr> Could you add a test case here: https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/build/buildpacks/build_test.go#L53 ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3584?email_source=notifications&email_token=AF4VPGAYIZIGXIANCTDBJR3Q7WO7NA5CNFSM4KLW36T2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ5VNCI#issuecomment-578508425>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF4VPGEJSAKYLKFET27TJO3Q7WO7NANCNFSM4KLW36TQ> .

[kissmikijr]

@kissmikijr Could you add a test case here: https://github.com/GoogleContainerTools/skaffold/blob/master/pkg/skaffold/build/buildpacks/build_test.go#L53?

@dgageot I have added a test case.

[kissmikijr]

I am not sure why did the Travis CI failed. I got that I should commit skaffold/deploy/Dockerfile from check-skaffold-builder.sh I tried to git add it but nothing happend. :/

[balopat]

I am not sure why did the Travis CI failed. I got that I should commit skaffold/deploy/Dockerfile from check-skaffold-builder.sh I tried to git add it but nothing happend. :/

I restarted the Travis build - it was a failing test in master that's fixed now.