Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to pass specific buildpacks when use buildpack artifact #3581

Closed
kissmikijr opened this issue Jan 26, 2020 · 3 comments
Closed

Be able to pass specific buildpacks when use buildpack artifact #3581

kissmikijr opened this issue Jan 26, 2020 · 3 comments
Labels
area/build build/buildpacks kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.

Comments

@kissmikijr
Copy link
Contributor

Expected behavior

Be able to specify which buildpacks should the builder use. In case your project need more than one.

Actual behavior

Not supported.

Information

  • Skaffold version: version...
  • Operating system: ...
  • Contents of skaffold.yaml:
buildpack:
  builder: "heroku/buildpacks"
  buildpacks:
    - heroku/php
    - heroku/nodejs

Steps to reproduce the behavior

Currently not supported.

  1. a clonable repository with the sample skaffold project
  2. skaffold <command>
  3. ...
@kissmikijr
Copy link
Contributor Author

I already did some digging, and have a working solution for this. But I can't make the hack/linter.sh to pass I got operation not permitted, any help would be appreciated.

@kissmikijr kissmikijr mentioned this issue Jan 26, 2020
Merged
7 tasks
@balopat balopat added build/buildpacks area/build kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence. labels Jan 26, 2020
@balopat
Copy link
Contributor

balopat commented Jan 26, 2020

cc @dgageot @briandealwis

@dgageot
Copy link
Contributor

dgageot commented Jan 28, 2020

Fixed with #3584

@dgageot dgageot closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build build/buildpacks kind/feature-request priority/awaiting-more-evidence Lowest Priority. May be useful, but there is not yet enough supporting evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dgageot @balopat @kissmikijr