-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding release comment management to all config.go #2917
adding release comment management to all config.go #2917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to Large PR Police and ask you to break it into 3 PRs :)
- support interface type in AST
- Add the new script to add commit
- Finally all the changes.
Thank you!
shouldErr: false, | ||
}, | ||
{ | ||
name: "supported types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you added support for interface
Type? is this test case for that that?
name: "supported types", | |
name: "supported interface types", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1dae8c2
to
3f6e5c3
Compare
Related to #2775.
Description
This "master PR" adds automation around managing comments on the config.go files that inform the user about whether the latest
config.go
is safe to modify or not (depending on whether it's released or not).The plan is to break this up to smaller PRs. However feedback is welcome here, and it is a working version that you can test for UX.
User facing changes
Only contributor facing changes.
Before
Currently the hack/check-schema-changes.sh script is the only way to know if the config that you're modifying is released or not (or checking manually).
After
This PR adds:
go run hack/versions/cmd/update_comments/main.go
release.sh
so that we flip the latest version to releasedinterface{}
type support that is inv1beta5
Next PRs.
to break this up to smaller PRs:
interface{}
type support that is inv1beta5
release
andnew_config
To finish #2775:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Reviewer Notes