Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better config versioning management #2775

Closed
4 of 5 tasks
balopat opened this issue Aug 30, 2019 · 0 comments · Fixed by #3723
Closed
4 of 5 tasks

Better config versioning management #2775

balopat opened this issue Aug 30, 2019 · 0 comments · Fixed by #3723
Assignees
@balopat
Labels
kind/todo implementation task/epic for the skaffold team meta/release priority/p1 High impact feature/bug.

Comments

@balopat
Copy link
Contributor

balopat commented Aug 30, 2019 •
edited
Loading

Specs: https://docs.google.com/document/d/e/2PACX-1vRBN1vHjSGbs3ZmdvyzzhBn48NjeuP4OiTTG5mec_YrRzNDL63pFa1Xy1rgCUNiQXTjAE1QyvCr5yxX/pub

Based on the above, I have some recommendations around what to do with regards to version management, I believe these would simplify our lives:

TODO:

  • fail new_version script if current version is unreleased
  • we should mark a version released/unreleased, by a comment on top the config.go file maintained - explaining how to do config changes
  • on every PR we should check for structural changes in schemas. Fail if there is a structural change in a released version.
  • in our release.sh script: if the latest version is unreleased, mark the latest version as released (in comment)
  • convert the above doc to a markdown / page on our skaffold.dev / DEVELOPMENT.md
@balopat balopat added meta/release kind/todo implementation task/epic for the skaffold team priority/p0 Highest priority. We are actively looking at delivering it. labels Aug 30, 2019
@balopat balopat self-assigned this Sep 3, 2019
@balopat balopat mentioned this issue Sep 4, 2019
Merged
This was referenced Sep 12, 2019
Merged
Merged
@tejal29 tejal29 mentioned this issue Sep 17, 2019
Merged
4 tasks
@nkubala nkubala added priority/p1 High impact feature/bug. and removed priority/p0 Highest priority. We are actively looking at delivering it. labels Sep 17, 2019
This was referenced Sep 20, 2019
Merged
Merged
Merged
balopat added a commit that referenced this issue Feb 22, 2020
@balopat
Link config management doc
c816505 
Fixes #2775.
@balopat balopat mentioned this issue Feb 22, 2020
Merged
dgageot pushed a commit that referenced this issue Feb 24, 2020
@balopat
Link config management doc (#3723)
918b78e 
* Link config management doc

Fixes #2775.

* public doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balopat balopat

Labels
kind/todo implementation task/epic for the skaffold team meta/release priority/p1 High impact feature/bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link config management doc GoogleContainerTools/skaffold
2 participants
@balopat @nkubala