Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build script for doc generation. #2884

Merged
merged 1 commit into from
Sep 13, 2019
Merged

Fix build script for doc generation. #2884

merged 1 commit into from
Sep 13, 2019

Conversation

tejal29
Copy link
Contributor

@tejal29 tejal29 commented Sep 13, 2019

The latest doc-modification job failed due
https://storage.googleapis.com/webhook-logs/logs-2879-1568411607494563296

Init container logs: 
 Cloning into 'skaffold-1'...
 
Container Logs: 
 + readonly BASE_URL=http://34.94.233.95:1313
+ BASE_URL=http://34.94.233.95:1313
+ cd docs
+ mkdir themes
mkdir: cannot create directory 'themes': File exists

@codecov
Copy link

codecov bot commented Sep 13, 2019

Codecov Report

Merging #2884 into master will not change coverage.
The diff coverage is n/a.

balopat
balopat approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try.. not sure I understand why it broke in the first place.

@balopat balopat merged commit 81426ed into GoogleContainerTools:master Sep 13, 2019
@tejal29 tejal29 mentioned this pull request Sep 16, 2019
Merged
@tejal29 tejal29 deleted the fix_docs branch September 18, 2019 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tejal29 @balopat @googlebot