-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs and tutorial for buildpacks #2879
Add docs and tutorial for buildpacks #2879
Conversation
Add docs and tutorial for using skaffold with buildpacks via the custom builder.
Codecov Report
|
Error creating deployment docs-controller-deployment-2879, please visit https://storage.googleapis.com/webhook-logs/logs-2879-1568411607494563296 to view logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the label docs-modifications to see the changes, but looks like its broken due to #2884
Great start! some nits.
Will check again when docs are generated.
Error creating deployment docs-controller-deployment-2879, please visit https://storage.googleapis.com/webhook-logs/logs-2879-1568414435741304973 to view logs. |
Error creating deployment docs-controller-deployment-2879, please visit https://storage.googleapis.com/webhook-logs/logs-2879-1568443021185774710 to view logs. |
@priyawadhwa Please rebase so we can check if #2884 fixed the issue |
There is another error
|
Please visit http://34.94.71.232:1313 to view changes to the docs. |
Hey @tejal29 -- incorporated your changes PTAL |
74c1367
to
f6fd9b3
Compare
Please visit http://34.94.233.95:1313 to view changes to the docs. |
01d165b
to
54aa315
Compare
Please visit http://34.94.233.95:1313 to view changes to the docs. |
Error creating deployment docs-controller-deployment-2879, please visit https://storage.googleapis.com/webhook-logs/logs-2879-1568663570220304046 to view logs. |
Error creating deployment, please see controller logs for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just a few more nits.
I am trying to see if we can make this tutorial as complete as possible.
If a user is landing on this page directly. (via google search results)
It would be good to link skaffold's getting started doc.
E.g. See https://cloud.google.com/go/getting-started/tutorial-app#before-you-begin
You can either,
Explicitly mention,
- Before you being, please see our getting started guide at http://skaffold.dev/docs/getting-started/#before-you-begin
- Or, like this page https://cloud.google.com/go/getting-started/using-structured-data
See how they mention
This page is part of a multi-page tutorial.
To start from the beginning and read the setup instructions, go to Go Bookshelf app.
We can also do something similar and say
This page describes how to use Buildpacks with skaffold.
To learn more about how to set up skaffold, see http://skaffold.dev/docs/getting-started
I don't mind either approach.
We should also have "Before you begin" Section and explicitly mention installing pack
and docker
.
Some users might skip it because its not mentioned :)
And then finally, a section on Cleaning Up.
|
||
## Tutorial | ||
|
||
Clone the Skaffold buildpacks [example](https://github.com/GoogleContainerTools/Skaffold/blob/master/examples/buildpacks/) for sample code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try to add a one line description on what the example does so that user's know what they are installing.
e.g. https://cloud.google.com/go/getting-started/tutorial-app
Clone the Skaffold buildpacks [example](https://github.com/GoogleContainerTools/Skaffold/blob/master/examples/buildpacks/) for sample code. | |
In this tutorial, you will deploy a single go based file app on a pod. | |
Clone the Skaffold buildpacks [example](https://github.com/GoogleContainerTools/Skaffold/blob/master/examples/buildpacks/) for sample code. |
```shell | ||
$ skaffold run --tail --default-repo <your repo> | ||
``` | ||
This will deploy Hello World in Go to your cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have cluster step up steps somewhere that we can point users to if they have never set up a cluster kubectl
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the getting-started guide might have it. If not we shd add it there.
Maybe we can do that in a separate PR.
@priyawadhwa Can you also please break this PR into 2.
This could be an example on how to add break docs into smaller changes. thanks |
…o buildpacks-docs
@tejal29 thanks for the feedback, I've incorporated it --- PTAL! |
cool. @priyawadhwa changes looks great! will take a look at the generated docs. |
Please visit http://34.94.71.232:1313 to view changes to the docs. |
$ pack set-default-builder heroku/buildpacks | ||
``` | ||
|
||
Take a look at the `build.sh` file, which uses `pack` to containerize source code with buildpacks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also link the http://skaffold.dev/docs/how-tos/builders/#custom-build-script-run-locally here. I think users might need help on what $image
and $PUSH_IMAGE
is.
```shell | ||
$ skaffold run --tail --default-repo <your repo> | ||
``` | ||
With this command, Skaffold will build `gcr.io/k8s-skaffold/skaffold-example` with buildpacks and deploy the application to Kubernetes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: k8s-skaffold
will be replaced by <your repo>
Add docs with tutorial for using skaffold with buildpacks via
the custom builder.
depends on #2893 (merged)