Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We must handle every profile field type #2726

Merged
merged 1 commit into from
Aug 28, 2019
Merged

We must handle every profile field type #2726

merged 1 commit into from
Aug 28, 2019

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 27, 2019

This would have caught #1688

Signed-off-by: David Gageot david@gageot.net

@dgageot
We must handle every profile field type
0c3e558 
This would have caught GoogleContainerTools#1688

Signed-off-by: David Gageot <david@gageot.net>
@codecov
Copy link

codecov bot commented Aug 28, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@dc6d62e). Click here to learn what that means.
The diff coverage is 0%.

Impacted Files Coverage Δ
pkg/skaffold/schema/profiles.go 88.07% <0%> (ø)

@nkubala nkubala merged commit 5cdff57 into GoogleContainerTools:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dgageot @nkubala @googlebot