Skip to content

Commit

Permalink
Merge pull request #2726 from dgageot/fail-not-warn
Browse files Browse the repository at this point in the history
We must handle every profile field type
  • Loading branch information
nkubala authored Aug 28, 2019
2 parents dc6d62e + 0c3e558 commit 5cdff57
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/profiles.go
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ func overlayProfileField(fieldName string, config interface{}, profile interface
}
return v.Interface()
default:
logrus.Warnf("Type mismatch in profile overlay for field '%s' with type %s; falling back to original config values", fieldName, v.Kind())
logrus.Fatalf("Type mismatch in profile overlay for field '%s' with type %s; falling back to original config values", fieldName, v.Kind())
return config
}
}

0 comments on commit 5cdff57

Please sign in to comment.