Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to kubectl forwarder #2661

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Add unit tests to kubectl forwarder #2661

merged 4 commits into from
Aug 20, 2019

Conversation

priyawadhwa
Copy link
Contributor

Add unit tests to kubectl forwarder, part of #2596

@priyawadhwa priyawadhwa mentioned this pull request Aug 15, 2019
Closed
@codecov
Copy link

codecov bot commented Aug 15, 2019

Codecov Report

Merging #2661 into master will increase coverage by 0.41%.
The diff coverage is 35%.

Impacted Files Coverage Δ
...g/skaffold/kubernetes/portforward/entry_manager.go 93.47% <100%> (ø) ⬆️
...affold/kubernetes/portforward/kubectl_forwarder.go 54.43% <31.57%> (+54.43%) ⬆️
pkg/skaffold/server/server.go 58.57% <0%> (ø) ⬆️

nkubala
nkubala approved these changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for doing this!

@priyawadhwa priyawadhwa merged commit 27db54b into GoogleContainerTools:master Aug 20, 2019
@priyawadhwa priyawadhwa deleted the kubectltest branch August 20, 2019 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat Awaiting requested review from balopat

@dgageot dgageot Awaiting requested review from dgageot

@tejal29 tejal29 Awaiting requested review from tejal29

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyawadhwa @nkubala @googlebot