Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add port forwarding unit & integration tests #2596

Closed
priyawadhwa opened this issue Aug 1, 2019 · 0 comments
Closed

Add port forwarding unit & integration tests #2596

priyawadhwa opened this issue Aug 1, 2019 · 0 comments
Labels
area/portforward area/testing Issues concerning the testing phase of Skaffold kind/todo implementation task/epic for the skaffold team

Comments

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Aug 1, 2019

Add integration tests for #2593 to cover:

  1. (Done with Add port forwarding integration test #2623) deleting a pod after port forwarding has occurred
  2. changing the skaffold config after a dev loop
  3. (Done with Monitor kubectl logs when port forwarding and retry on error #2543)making sure port forwarding works on the second dev loop

(Done with - #2648) Also, add constructor for portForwardEntry

Add unit tests for:

  1. (Done with Add unit tests to kubectl forwarder #2661) kubectl forwarder
  2. (Done with Add unit test for LoadOrStore  #2649) loadorstore
@priyawadhwa priyawadhwa added area/portforward area/testing Issues concerning the testing phase of Skaffold labels Aug 1, 2019
@priyawadhwa priyawadhwa changed the title Add port forwarding integration tests Add port forwarding unit & integration tests Aug 1, 2019
@balopat balopat added the kind/todo implementation task/epic for the skaffold team label Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/portforward area/testing Issues concerning the testing phase of Skaffold kind/todo implementation task/epic for the skaffold team
Projects
None yet
Development

No branches or pull requests

2 participants