Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize port forwarding #2586

Closed
priyawadhwa opened this issue Jul 31, 2019 · 1 comment
Closed

Stabilize port forwarding #2586

priyawadhwa opened this issue Jul 31, 2019 · 1 comment
Assignees
Labels
area/portforward Epic kind/todo implementation task/epic for the skaffold team

Comments

@priyawadhwa
Copy link
Contributor

priyawadhwa commented Jul 31, 2019

We've seen many issues around port-forwarding with the last few releases:

Port forwarding doesn't work anymore since update 0.33.0 -> 0.34.0 (#2523)
Port forwarding not work when pods recreated (#2408)

This issue will detail a plan to fix known issues and stabilize port forwarding.

  1. (In progress - Add pods stability for health check. #2374) Implement pod health check. This way, we will wait for pods to be running before attempting port forwarding, which should prevent the "Pod Status = Pending" error in kubectl port-forward I saw when reproducing this comment

  2. (Depends on Add pods stability for health check. #2374) Make sure pod is running before sending a port forward event for the IDEs even on retries

  3. Add termination events for port forwards (Add termination events for port forwarding #2584)

  4. (Depends on Point 2) Clarify the port forwarding log message to indicate we are attempting port forwarding (Clarify port forwarding log message #2585)

  5. (Done - Add port forwarding unit & integration tests #2596) Add integration tests for Cleaner kubectl port-forward retry logic #2593

  6. (Done with Select resources by UUID label #2609) Filter services by run ID instead of by K8sManagedByLabel, so that extra services running in cluster aren't port forwarded

  7. (Done with Don't look up services in all namespaces. #2651) Make sure portforwarding doesn't require access to all namespaces

  8. Consider a redesign if the above steps don't stabilize port forwarding to our satisfaction.

@balopat
Copy link
Contributor

balopat commented Aug 2, 2019

we should address #2599 as well here

@priyawadhwa priyawadhwa self-assigned this Aug 12, 2019
@balopat balopat added the kind/todo implementation task/epic for the skaffold team label Aug 14, 2019
@priyawadhwa priyawadhwa assigned tejal29 and unassigned priyawadhwa Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/portforward Epic kind/todo implementation task/epic for the skaffold team
Projects
None yet
Development

No branches or pull requests

4 participants